OCPBUGS-98617: Fixes daemonset Progressing=True logic#490
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-98617, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe DaemonSet rollout completion predicate now uses observed generation and currently scheduled pods. Tests cover incomplete updates, generation lag, node reboot, misscheduled pods, node scale-up, and initial deployment with no scheduled pods. ChangesDaemonSet rollout tracking
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pipeline auto |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pkg/controllers/clusteroperator_controller_test.go (1)
1313-1409: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winStruct literals not gofmt-aligned.
golangci-lint reports a goimports formatting violation starting at Line 1314. Checking the field-value alignment in these new
DaemonSetStatus{}literals (e.g.ObservedGeneration: 1,vsDesiredNumberScheduled: 3,), the value columns are inconsistent with whatgofmt/goimportswould produce. Rungofmt -w/goimports -won this file.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/controllers/clusteroperator_controller_test.go` around lines 1313 - 1409, Run gofmt or goimports on the test file to align the field-value columns in the DaemonSetStatus struct literals within the isDaemonSetRolloutComplete tests. Preserve all test cases and logic while applying only the formatter’s required alignment changes.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@pkg/controllers/clusteroperator_controller_test.go`:
- Around line 1313-1409: Run gofmt or goimports on the test file to align the
field-value columns in the DaemonSetStatus struct literals within the
isDaemonSetRolloutComplete tests. Preserve all test cases and logic while
applying only the formatter’s required alignment changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 25a825a6-ba87-41a6-b778-cd36f4c90164
📒 Files selected for processing (2)
pkg/controllers/clusteroperator_controller.gopkg/controllers/clusteroperator_controller_test.go
Updates our daemonset status watching logic to not flip Progressing=True when scaling up nodes.
781b669 to
08a614d
Compare
|
@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
1 similar comment
|
@theobarberbany: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview-serial |
|
@theobarberbany: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/785b2780-8043-11f1-813f-8c33d30b0fd4-0 |
|
/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview-serial |
|
@theobarberbany: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/277f22b0-806d-11f1-9d9b-a9422b81550c-0 |
|
/retest |
|
Test |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-98617, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/approve This bug contributes to an OCP 5 upgrade release blocking feature, IMO it's critical |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest These look like flakes, hopefully they're fixed now |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@theobarberbany: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@theobarberbany: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@theobarberbany: Jira Issue Verification Checks: Jira Issue OCPBUGS-98617 Jira Issue OCPBUGS-98617 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 5.0.0-0.nightly-2026-07-17-034502 |
4 participants
Updates our daemonset status watching logic to not flip Progressing=True when scaling up nodes.
Summary by CodeRabbit