Install perl-ExtUtils-MakeMaker in the backport agent images#606
Merged
majamassarini merged 1 commit intoJun 18, 2026
Merged
Conversation
Several perl packages run `perl -MExtUtils::MakeMaker` during %prep (e.g. perl-DBI calls ExtUtils::MM_Unix->fixin). Without perl-ExtUtils-MakeMaker in the agent image, that aborts with "BEGIN failed--compilation aborted", so `rhpkg/centpkg prep` fails before the CVE patch is even applied and the backport errors out. Add perl-ExtUtils-MakeMaker to both the c9s and c10s images, alongside the other build macros, so perl package %prep can run. Seen on RHEL-184984 (perl-DBI, rhel-9.8.z), where every backport attempt failed in %prep. Assisted-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the perl-ExtUtils-MakeMaker package to the list of installed dependencies in both Containerfile.c10s and Containerfile.c9s. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
opohorel
approved these changes
Jun 18, 2026
Contributor
|
This seems like a missing dependency in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several perl packages invoke
perl -MExtUtils::MakeMakerduring%prep(e.g. perl-DBI runsExtUtils::MM_Unix->fixin(...)). The backport agent images installperl-srpm-macrosbut notperl-ExtUtils-MakeMaker, so that call aborts:rhpkg/centpkg prepthen fails before the CVE patch is even fetched, and the backport errors out.Seen in production
RHEL-184984 (perl-DBI, CVE-2026-9698, rhel-9.8.z) — triggered via
ymir_todo, every backport attempt failed in%prepwith the above, landing onymir_backport_errored.Fix
Add
perl-ExtUtils-MakeMakerto bothContainerfile.c9sandContainerfile.c10s, alongside the other build macros, so perl package%prepcan run. (It pulls in the perl interpreter/toolchain it needs.) Kept the two images in sync.Assisted-by: Claude Opus 4.8 (1M context) noreply@anthropic.com