Skip to content

Fix double-bracketing of choices in synopsis#3578

Merged
Rowlando13 merged 1 commit into
pallets:stablefrom
kdeldycke:fix-choice-double-brackets
Jun 13, 2026
Merged

Fix double-bracketing of choices in synopsis#3578
Rowlando13 merged 1 commit into
pallets:stablefrom
kdeldycke:fix-choice-double-brackets

Conversation

@kdeldycke

@kdeldycke kdeldycke commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

A small rendering issue of choices being enclosed into double-brackets when argument is optional.

Issue was likely unnoticed in the original #1272 / #1273 PR.

This mirrors the similar fix I implemented for commands in #3507

@kdeldycke kdeldycke changed the base branch from main to stable June 10, 2026 13:28
@kdeldycke kdeldycke added the f:help feature: help text label Jun 10, 2026
@kdeldycke kdeldycke force-pushed the fix-choice-double-brackets branch from 6fdd976 to b640737 Compare June 10, 2026 13:29
@kdeldycke kdeldycke added this to the 8.4.2 milestone Jun 10, 2026
@kdeldycke kdeldycke force-pushed the fix-choice-double-brackets branch from b640737 to 762c97e Compare June 10, 2026 13:31
@kdeldycke kdeldycke requested review from Rowlando13 and davidism June 10, 2026 13:32
@kdeldycke kdeldycke linked an issue Jun 10, 2026 that may be closed by this pull request
@Rowlando13 Rowlando13 merged commit 09195f6 into pallets:stable Jun 13, 2026
12 checks passed
@kdeldycke kdeldycke deleted the fix-choice-double-brackets branch June 13, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f:help feature: help text

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Choices.get_metavar makes all choices look optional

2 participants