fix: reuse created-once channels so queued requests don't get stuck on replaced channels#2470
Open
henderkes wants to merge 3 commits into
Open
fix: reuse created-once channels so queued requests don't get stuck on replaced channels#2470henderkes wants to merge 3 commits into
henderkes wants to merge 3 commits into
Conversation
henderkes
force-pushed
the
fix/reload_timeout
branch
from
777ea43 to
c7ec04a
Compare
henderkes
force-pushed
the
fix/reload_timeout
branch
from
a41001f to
fdd8f60
Compare
| } | ||
|
|
||
| if mainThread.maxThreads <= mainThread.numThreads { | ||
| scaleChan = nil |
Contributor
There was a problem hiding this comment.
scalechan should be nil if autoscaling is inactive (to avoid the select overhead). Does keeping this also cause race detection?
Contributor
Author
There was a problem hiding this comment.
I'll need to test, it wasn't for the race detection but to work the same way as requestchan. Can revert and leave a comment why it's different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2469