explain-joins: reword "create ... on disk" as "spill ... to disk"#23346
explain-joins: reword "create ... on disk" as "spill ... to disk"#23346yahonda wants to merge 1 commit into
Conversation
In the hash join section, one sentence said TiDB "might create the `Build`
operator ... on disk", which is confusing. Align it with the wording used
later in the same page ("spill the `Build` operator ... to disk"), which more
accurately describes spilling the operator's data to temporary storage.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Runtime Statistics documentation now states that TiDB may spill the hash join ChangesRuntime Statistics
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
In the Hash Join section of
explain-joins.md, one sentence describes the on-disk behavior as:"create the
Buildoperator on disk" is confusing — the operator is not created on disk; its data is spilled to temporary storage. Later on the same page, the system-variables section already describes the same behavior with clearer wording:This PR aligns the earlier sentence with that clearer, consistent wording ("spill ... to disk").
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
N/A — documentation wording clarification.
🤖 Generated with Claude Code
Summary by CodeRabbit