Skip to content

docs: update hugo version and add windows notes for local preview#6910

Open
oindrilakha12-ui wants to merge 2 commits into
pipe-cd:masterfrom
oindrilakha12-ui:fix/docs-windows-hugo
Open

docs: update hugo version and add windows notes for local preview#6910
oindrilakha12-ui wants to merge 2 commits into
pipe-cd:masterfrom
oindrilakha12-ui:fix/docs-windows-hugo

Conversation

@oindrilakha12-ui

@oindrilakha12-ui oindrilakha12-ui commented Jun 13, 2026

Copy link
Copy Markdown

Fixes #6741 by updating the minimum required Hugo version to v0.148.2 and adding Windows PowerShell workaround notes for the \make run/site\ command.

The note reads the release version dynamically from the \RELEASE\ file at the repo root so it never goes stale across releases.

@oindrilakha12-ui

Copy link
Copy Markdown
Author

@caniszczyk ,please review it

@oindrilakha12-ui

Copy link
Copy Markdown
Author

@Linutux ,please review it

@khanhtc1202

Copy link
Copy Markdown
Member

/cc @eeshaanSA @rahulshendre

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 0.148.2 for the Hugo version, not 0.120.0
#6930 (Netlify migration) edits the same README line and already sets 0.148.2, so match it, to avoid conflicts

No need to touch the archived versions (v0.39-v0.43), keep it to docs-dev, v1.0, v0.56, you can skip v0.55 as well
make run/site reads RELEASE from the current release tag, so v0.0.0 will show the wrong version in the site's version dropdown

not a blocker just for consistency, the note section won't get our usual blue border right now, it's nested, just pull it out it should render properly, also if you don't mind please add a screenshot as well : D

to give you a better idea, PTAL

Current
Image

Our style
Image

@rahulshendre

Copy link
Copy Markdown
Contributor

@oindrilakha12-ui, any updates on this one 👀

@oindrilakha12-ui oindrilakha12-ui force-pushed the fix/docs-windows-hugo branch from 97b3a75 to c3b6d21 Compare July 5, 2026 09:44
@oindrilakha12-ui

Copy link
Copy Markdown
Author

Hi @rahulshendre, thank you for the detailed review! I've addressed all your feedback:
✅ Updated Hugo version from 0.120.0 to 0.148.2 to match PR #6930 and avoid conflicts
✅ Reverted changes to archived versions (v0.39–v0.43) — kept updates only to docs-dev, v0.56.x, and v1.0.x
✅ Fixed $env:RELEASE from "v0.0.0" to "v0.56.0" (current release tag) so the version dropdown shows correctly
✅ Pulled the Windows note out of the nested list so it renders with the proper blue border styling
Please let me know if anything else needs to be changed.

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates @oindrilakha12-ui, we are almost there

one thing on the release value, the current tag is v0.57.0 now, not v0.56.0 (it's the tag: line in the RELEASE file at the repo root).

since this keeps changing in every release, I think the note should say, grab the value from that file and keep the command as an example, otherwise this goes stale in all 6 pages every time we release.
what do you think?

tiny nit: the PR description still says v0.120.0, please update it
and add the screenshot of the rendered note when you get a chance : D

> **Note for Windows users:**
> The `make run/site` command uses `make` and `grep`, which are not natively available in Windows PowerShell. You can either use an environment like WSL or run the Hugo command manually in PowerShell:
> ```powershell
> $env:RELEASE = "v0.56.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one

@oindrilakha12-ui oindrilakha12-ui force-pushed the fix/docs-windows-hugo branch from c3b6d21 to 4f883ca Compare July 5, 2026 10:26
@oindrilakha12-ui

oindrilakha12-ui commented Jul 5, 2026

Copy link
Copy Markdown
Author

@rahulshendre! Thank you for the catch addressed all 3 points:

✅ Replaced the hardcoded version with a dynamic PowerShell command that reads the version directly from the RELEASE file at the repo root, so it never goes stale across releases:
powershell

$env:RELEASE = (Select-String -Path RELEASE -Pattern "^tag:").Line.Split(":")[1].Trim()
hugo server --source=docs
✅ Updated the PR description (removed mention of v0.120.0, now correctly says v0.148.2)
✅ Screenshot of the rendered note with the blue border below
rendered_note_preview_1783247105359

Please let me know if anything else needs to be changed

@oindrilakha12-ui oindrilakha12-ui force-pushed the fix/docs-windows-hugo branch from 4f883ca to 383f9b9 Compare July 5, 2026 10:42

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit
could you add the same change to the two contributing pages under docs-v0.57.x as well? just copy them, keeping the v0.56 ones is fine as well

also, the image you posted isn't a real screenshot, it looks ai generated, I ran the site locally and the note renders fine with the blue border, so the content is fine, but next time please share an actual image, or just say you couldn't run it : )

Image

after the v0.57.x copy this is good to go, thank you 🙌

Signed-off-by: Oindrila Khan <oindrilakha12@gmail.com>
@oindrilakha12-ui oindrilakha12-ui force-pushed the fix/docs-windows-hugo branch from 383f9b9 to 872df24 Compare July 5, 2026 11:22

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
thank you @oindrilakha12-ui

@oindrilakha12-ui

Copy link
Copy Markdown
Author

@rahulshendre, really sorry about the AI screenshot I couldn't run the site locally on Windows and should have just said that instead will make sure to be upfront next time!

Added the same changes to docs-v0.57.x as well both contributing-documentation.md and contributing-blogs.md are updated now. Let me know if there's anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs local preview fails on Windows PowerShell and Hugo 0.92.1

3 participants