ci: fix first-time contributor welcome check#6929
Conversation
Signed-off-by: Yashagarwal9798 <yashagarwal9798@gmail.com>
|
@Warashi @Ayushmore1214 @rahulshendre Could you please review this PR? |
|
@Yashagarwal9798 could you run this once locally and drop a screenshot here ? |
|
@Ayushmore1214 I tested it in my fork by opening a test PR from Since the fixed workflow was on the base branch, the 
|
There was a problem hiding this comment.
@Yashagarwal9798
The pull_request_target workflow runs on the default branch, not the PR's base branch.
Additionally, your fork repository has no PRs other than your test PR. So it's not enough to test this workflow, because pulls.length is less than or equal to 1 regardless of the author.
|
Duplicate of #6730 |
|
@harshitghagre your PR touches the SHA tags and this is about the core logic of the worklfow, so its not a duplicate as far as I unserstand |
|
If you think there is some overlapping go ahead point it out specifically, thanks! |
|
@Ayushmore1214 You're right, calling it a duplicate wasn't correct. I just meant there might be some overlap, not that both PRs solve the same thing |
4 participants
What this PR does:
Fixes the first-time contributor welcome workflow to correctly check pull requests opened by the PR author.
It now uses GitHub search with
author:<username>instead of the unsupportedcreatorparameter.Why we need it:
The old check could look at unrelated recent pull requests and incorrectly skip the welcome comment.
This ensures first-time contributors get the welcome message on their first pull request.
Which issue(s) this PR fixes:
Fixes #6918
Does this PR introduce a user-facing change?:
No.
Users are not affected. This only changes a GitHub Actions workflow.
No.
No migration is needed.