Use %w for error wrapping in controller.cancelDeployment#6936
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelDeploymentnow wraps the error returned byReportDeploymentCompletedwith%winstead of%v, so callers can useerrors.Is/errors.Asto inspect the underlying cause.Why this matters
The cancellation path formatted the reporting error with
%v, which flattens it to a string and breaks error-chain inspection for any caller that wants to branch on the wrapped error. Switching to%wpreserves the chain while keeping the existing message format. Reported in #6932.Testing
Added a regression test that drives
cancelDeploymentwith a fake API client returning a sentinel error and assertserrors.Ismatches the wrapped error, so the test fails if the wrapping regresses to%v. The controller package tests pass.Closes #6932