Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/js/dashboard/stats-query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export type ApiFilter =
export type NonTimeDimension =
| apiTypes.SimpleFilterDimensions
| apiTypes.CustomPropertyFilterDimensions
| apiTypes.GoalDimension

export type TimeDimension = apiTypes.TimeDimensions | 'time:minute'

Expand Down
58 changes: 0 additions & 58 deletions assets/js/dashboard/stats/behaviours/conversions.js

This file was deleted.

79 changes: 79 additions & 0 deletions assets/js/dashboard/stats/behaviours/conversions.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import React, { ReactNode, useCallback } from 'react'

import {
DimensionCellWithBar,
DimensionCellWithBarProps,
IndexBreakdown
} from '../reports/index-breakdown'
import {
BREAKDOWN_REPORTS,
BreakdownReportKey
} from '../reports/reports-config'
import { QueryApiResponse, QueryResultRow } from '../../api'
import { NonTimeDimension } from '../../stats-query'
import { FilterInfo } from '../../components/drilldown-link'
import {
BEHAVIOURS_BAR_COLOR,
BEHAVIOURS_METRIC_COLUMN_WIDTH,
BEHAVIOURS_METRICS_HIDDEN_ON_MOBILE
} from '.'
import { useSiteContext } from '../../site-context'

type ConversionsProps = {
onDataReady?: (data: QueryApiResponse) => void
onGoalFilterClick?: (goalName: string) => void
}

export default function Conversions({
onDataReady,
onGoalFilterClick
}: ConversionsProps): ReactNode {
const site = useSiteContext()
const reportConfig = BREAKDOWN_REPORTS[BreakdownReportKey.goals]

/*global BUILD_EXTRA*/
const metrics = reportConfig.getMetrics({
isRevenueAvailable: BUILD_EXTRA && site.revenueGoals.length > 0
})

const DimensionElement = useCallback(
(props: DimensionCellWithBarProps) => {
const goalName = props.row.dimensions[0]
return (
<DimensionCellWithBar
{...props}
barClassName={BEHAVIOURS_BAR_COLOR}
text={goalName}
getFilterInfo={getGoalsFilterInfo}
onClick={() => onGoalFilterClick && onGoalFilterClick(goalName)}
/>
)
},
[onGoalFilterClick]
)

return (
<IndexBreakdown
metrics={metrics}
dimensions={reportConfig.dimensions}
dimensionLabel={reportConfig.dimensionLabel}
alwaysOnFilters={reportConfig.alwaysOnFilters}
DimensionElement={DimensionElement}
onDataReady={onDataReady}
hideMetricsIfAllNull={['total_revenue', 'average_revenue']}
hideMetricsOnMobile={BEHAVIOURS_METRICS_HIDDEN_ON_MOBILE}
metricColumnWidth={BEHAVIOURS_METRIC_COLUMN_WIDTH}
/>
)
}

export function getGoalsFilterInfo(
_dimension: NonTimeDimension,
row: QueryResultRow
): FilterInfo {
const goalName = row.dimensions[0]
return {
prefix: 'goal',
filter: ['is', 'goal', [goalName]]
}
}
Loading
Loading