Send unroute to the page instead of the context (fix #96)#110
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Page::unroute() delegated to BrowserContext::unroute(), a no-op because the route is registered on the page object server-side. Send page.unroute and handle it in the PageHandler registry. Fixes playwright-php#96
smnandre
force-pushed
the
sa/page-unroute
branch
from
July 21, 2026 16:58
1119c92 to
f89cc82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page::unroute()delegated toBrowserContext::unroute(), a no-op because the route is registered on the page object server-side.Send
page.unrouteand handle it in the PageHandler registry.Fixes #96