Transport request bodies as base64 postDataBuffer#116
Merged
Conversation
extractRequestData never shipped postDataBuffer, so RequestInterface::postDataBuffer() always returned null, and postData() corrupts non-UTF8 bytes in the JSON transport. The server now sends the raw body base64-encoded and Request::postDataBuffer() decodes it. Functional tests intercept a binary POST and assert byte-for-byte equality.
smnandre
force-pushed
the
sa/post-data-buffer
branch
from
July 21, 2026 17:33
357e8f8 to
ef8a873
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractRequestDatanever shippedpostDataBuffer, soRequestInterface::postDataBuffer()always returned null. Worse,postData()corrupts non-UTF8 bytes on their way through the JSON transport, so intercepted binary POST bodies (file uploads, some multipart payloads) arrive mangled with no way to recover them.The server now sends the raw body base64-encoded in a
postDataBufferfield andRequest::postDataBuffer()decodes it. Functional tests intercept a binary and a text POST and assert byte-for-byte equality.