Remove setAccessible calls, no-ops since PHP 8.1#117
Merged
Conversation
Reflection reaches private and protected members without permission since PHP 8.1, which made these calls do nothing. PHP 8.5 deprecates the method, so they now emit a deprecation on the newest version of the CI matrix while still doing nothing on every other one. The library requires PHP ^8.2, one version above the floor where the method stopped having an effect, so no supported runtime needs them. The surrounding setValue() and getValue() calls work unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflection reaches private and protected members without permission since PHP 8.1.