Skip to content

Allow duplicate cookie family names#4316

Merged
And1sS merged 13 commits into
masterfrom
allow-duplicate-cookie-family-names
Jul 15, 2026
Merged

Allow duplicate cookie family names#4316
And1sS merged 13 commits into
masterfrom
allow-duplicate-cookie-family-names

Conversation

@Lightwood13

Copy link
Copy Markdown
Collaborator

This pull request allows different bidders to have the same cookie family name if they have the same vendor id and usersync configuration. This change is done to allow merging the new msft bidder.

@marki1an marki1an requested review from And1sS and removed request for And1sS December 31, 2025 11:16
@Net-burst Net-burst mentioned this pull request Jan 7, 2026
1 task
@osulzhenko osulzhenko added do not merge Not the time for merging yet work in progress Signals not finished work labels Apr 28, 2026
@Lightwood13 Lightwood13 force-pushed the allow-duplicate-cookie-family-names branch from eec6d37 to 2e601ed Compare May 7, 2026 13:36
@Lightwood13 Lightwood13 force-pushed the allow-duplicate-cookie-family-names branch from 2e601ed to 035c00c Compare May 7, 2026 16:03
# Conflicts:
#	src/main/java/org/prebid/server/bidder/UsersyncInfoFactory.java
#	src/main/java/org/prebid/server/cookie/CookieSyncService.java
#	src/main/java/org/prebid/server/handler/SetuidHandler.java
#	src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java
#	src/main/java/org/prebid/server/spring/config/bidder/TaboolaConfiguration.java
#	src/test/java/org/prebid/server/bidder/BidderCatalogTest.java
#	src/test/java/org/prebid/server/bidder/UsersyncInfoFactoryTest.java
#	src/test/java/org/prebid/server/bidder/UsersyncMethodChooserTest.java
#	src/test/java/org/prebid/server/cookie/CookieSyncServiceTest.java
#	src/test/java/org/prebid/server/handler/SetuidHandlerTest.java
@And1sS And1sS added the PBS 4.0 label Jul 14, 2026
CTMBNara
CTMBNara previously approved these changes Jul 15, 2026
And1sS
And1sS previously approved these changes Jul 15, 2026
@osulzhenko osulzhenko dismissed stale reviews from And1sS and CTMBNara via f52b215 July 15, 2026 15:19
@And1sS And1sS merged commit d6a64e8 into master Jul 15, 2026
6 of 8 checks passed
@And1sS And1sS deleted the allow-duplicate-cookie-family-names branch July 15, 2026 15:21
@And1sS And1sS removed do not merge Not the time for merging yet work in progress Signals not finished work labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Syncer: Allow Duplicate Syncer Key For Identical Config

5 participants