Skip to content

Reduce Blankslate small size padding#7930

Open
Copilot wants to merge 9 commits into
mainfrom
copilot/update-blankslate-small-size-padding
Open

Reduce Blankslate small size padding#7930
Copilot wants to merge 9 commits into
mainfrom
copilot/update-blankslate-small-size-padding

Conversation

Copilot AI commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Closes https://github.com/github/primer/issues/6240

Blankslate size="small" did not meaningfully reduce padding for dense layouts. This updates size padding so small is visibly tighter while medium and large use the requested default spacing.

Changelog

New

Changed

  • Blankslate spacing
    • small: var(--base-size-16)
    • medium / large: var(--base-size-24)
<Blankslate size="small">...</Blankslate>

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Review the small, medium, and large Blankslate variants to confirm the updated padding scale feels balanced in compact containers.

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 42856c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Blankslate to allow rendering in tighter spaces Reduce Blankslate small size padding Jun 5, 2026
Copilot AI requested a review from joshblack June 5, 2026 22:00
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 8, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 8, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7930 June 8, 2026 19:26 Inactive
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
@joshblack joshblack marked this pull request as ready for review June 8, 2026 20:12
@joshblack joshblack requested a review from a team as a code owner June 8, 2026 20:12
Copilot AI review requested due to automatic review settings June 8, 2026 20:12
@joshblack joshblack added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Jun 8, 2026
@joshblack joshblack requested a review from lukasoppermann June 8, 2026 20:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts @primer/react’s Blankslate spacing scale so size="small" is meaningfully denser, while medium/large use a tighter default padding. This fits into the component styling system by updating the CSS module tokens and adding a regression test + changeset for the consumer-facing styling change.

Changes:

  • Update Blankslate padding tokens: small--base-size-16, medium/large--base-size-24.
  • Add a unit test that asserts the CSS variable values for each size variant.
  • Refactor Storybook Vite host allowlist configuration to use a shared constant (and add a core.allowedHosts entry).
Show a summary per file
File Description
packages/styled-react/.storybook/main.ts Extracts a shared STORYBOOK_ALLOWED_HOSTS constant and applies it to Vite server config (and adds core.allowedHosts).
packages/react/src/Blankslate/Blankslate.test.tsx Adds a stylesheet-rule based test asserting --blankslate-padding values for small/medium/large.
packages/react/src/Blankslate/Blankslate.module.css Updates --blankslate-padding for size variants and adds a container-query override for small.
packages/react/.storybook/main.ts Same Storybook allowed-hosts refactor as styled-react Storybook config (and adds core.allowedHosts).
package-lock.json Updates locked workspace/version metadata to match the current package versions.
.changeset/tidy-blankslate-padding.md Adds a patch changeset for the consumer-facing Blankslate spacing adjustment.

Copilot's findings

  • Files reviewed: 5/72 changed files
  • Comments generated: 3

Comment thread packages/react/src/Blankslate/Blankslate.module.css Outdated
Comment thread packages/react/.storybook/main.ts
Comment thread packages/styled-react/.storybook/main.ts
@github-actions github-actions Bot requested a deployment to storybook-preview-7930 June 8, 2026 20:16 Abandoned
@github-actions github-actions Bot temporarily deployed to storybook-preview-7930 June 8, 2026 20:26 Inactive
@joshblack joshblack requested a review from francinelucca June 9, 2026 16:54
@github-actions github-actions Bot requested a deployment to storybook-preview-7930 June 9, 2026 16:56 Abandoned
@joshblack joshblack removed the integration-tests: skipped manually Changes in this PR do not require an integration test label Jun 9, 2026
@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  CI   Passed
skipped  VRT   skipped
Passed  Projects   Passed

VRT check ensures that when visual differences are detected, the PR cannot proceed until someone acknowledges the changes by adding the "visual difference acknowledged" label.

Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants