Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions e2e/components/Axe.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ const SKIPPED_TESTS = [
'components-flash-features--with-icon-action-dismiss', // TODO: Remove once color-contrast issues have been resolved
'components-flash-features--with-icon-and-action', // TODO: Remove once color-contrast issues have been resolved
'components-filteredactionlist--default',
// TODO: Remove these once FilteredActionList feature stories no longer trigger label/nested-interactive axe violations.
'components-filteredactionlist-features--loading-with-body-skeleton',
'components-filteredactionlist-features--loading-with-body-spinner',
'components-filteredactionlist-features--radio-select',
'components-filteredactionlist-features--virtualized-list',
'components-filteredactionlist-features--with-groups',
'components-filteredactionlist-features--with-no-results-message',
'components-pagelayout-performance-tests--medium-content',
'components-pagelayout-performance-tests--heavy-content',
]
Expand Down
59 changes: 58 additions & 1 deletion e2e/components/FilteredActionList.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,58 @@ const stories = [
title: 'With Long Items',
id: 'components-filteredactionlist-examples--with-long-items',
},
{
title: 'Multi Select With Select All',
id: 'components-filteredactionlist-features--multi-select-with-select-all',
},
{
title: 'Single Select',
id: 'components-filteredactionlist-features--single-select',
},
{
title: 'Radio Select',
id: 'components-filteredactionlist-features--radio-select',
},
{
title: 'Select All Selected',
id: 'components-filteredactionlist-features--select-all-selected',
},
{
title: 'With Disabled Items',
id: 'components-filteredactionlist-features--with-disabled-items',
},
{
title: 'With Groups',
id: 'components-filteredactionlist-features--with-groups',
},
{
title: 'With No Results Message',
id: 'components-filteredactionlist-features--with-no-results-message',
},
{
title: 'Default Empty State',
id: 'components-filteredactionlist-features--default-empty-state',
},
{
title: 'Custom Item Rendering',
id: 'components-filteredactionlist-features--custom-item-rendering',
},
// {
// title: 'Loading In Input',
// id: 'components-filteredactionlist-features--loading-in-input',
// },
// {
// title: 'Loading With Body Spinner',
// id: 'components-filteredactionlist-features--loading-with-body-spinner',
// },
// {
// title: 'Loading With Body Skeleton',
// id: 'components-filteredactionlist-features--loading-with-body-skeleton',
// },
{
title: 'Virtualized List',
id: 'components-filteredactionlist-features--virtualized-list',
},
] as const

test.describe('FilteredActionList', () => {
Expand All @@ -26,7 +78,12 @@ test.describe('FilteredActionList', () => {
})

// Default state
await expect(page).toHaveScreenshot(`FilteredActionList.${story.title}.${theme}.png`)
await expect(page).toHaveScreenshot(`FilteredActionList.${story.title}.${theme}.png`, {
animations: 'disabled',
caret: 'hide',
// 0.02 ratio (2%) absorbs small cross-environment pixel shifts from virtualization.
...(story.title === 'Virtualized List' ? {maxDiffPixelRatio: 0.02} : {}),
})
})
}
})
Expand Down
Loading
Loading