[DYNAREC] Auto-initialize Zydis for dynarec dump in trace builds#4049
[DYNAREC] Auto-initialize Zydis for dynarec dump in trace builds#4049Mikura-Kyouka wants to merge 1 commit into
Conversation
|
Your change would make Zydis to initialize all the time, wich is something we do not want. It should initialize only when needed. |
Why? |
We don't need to load stuffs we don't use. Why having more memory consumed for nothing? |
|
Only if you enabled |
|
Still, I don't want lib loaded if we don't use it. Adding a check of dump or trace enable is easy enough, I don't see why we shouldn't keep the test. |
|
My intention is that I think it is not intuitive to use |
I understand, and I aggree but I think there is a need for a env. var. option for that. |
| __builtin_prefetch((void*)addr, 0, 0); | ||
| emu->prev2_ip = emu->old_ip; | ||
| if(my_context->dec && IsTraceAddr(addr)) | ||
| if(my_context->dec && BOX64ENV(trace) && strcmp(BOX64ENV(trace), "0") && IsTraceAddr(addr)) |
There was a problem hiding this comment.
try to avoid the use of strcmp in the main loop of the interpreter.
|
|
||
| path_collection_t box64_emulated_libs; // Collection of libs that should not be wrapped | ||
|
|
||
| int x64trace; |
There was a problem hiding this comment.
why removing this variable? you could use it instead to know when instruction trace is enabled (instead of when zydis is used for dump purpose for example)
3 participants
No description provided.