Init runtime PAL in RunnerTest (forward fix for D108707577)#20319
Conversation
Summary: Forward fix for D108707577 (llm_runner: plumb prefill temperature, #20244). The new test RunnerTest.TextTokenGeneratorRejectsTemperatureOutOfRange aborts: [ RUN ] RunnerTest.TextTokenGeneratorRejectsTemperatureOutOfRange ExecuTorch PAL must be initialized before call to et_pal_current_ticks() *** Signal 6 (SIGABRT) *** The new test drives the temperature-rejection path, which emits an ET_LOG (and thus calls et_pal_current_ticks()) before any model load. The RunnerTest fixture never initializes the ExecuTorch runtime, so the timer call aborts. The valid- temperature tests in the same fixture pass because their happy path does not log. Fix: initialize the runtime in RunnerTest::SetUp(), matching the established pattern used by the sibling tests in this same directory (test_text_prefiller, test_util, test_wav_loader all call executorch::runtime::runtime_init() in SetUp()). Applied to both the fbcode and xplat copies. Differential Revision: D108831322
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20319
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated FailuresAs of commit 3cc44f5 with merge base 218cc45 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108831322. |
This PR needs a
|
Summary:
Forward fix for D108707577 (llm_runner: plumb prefill temperature, #20244).
The new test RunnerTest.TextTokenGeneratorRejectsTemperatureOutOfRange aborts:
[ RUN ] RunnerTest.TextTokenGeneratorRejectsTemperatureOutOfRange
ExecuTorch PAL must be initialized before call to et_pal_current_ticks()
*** Signal 6 (SIGABRT) ***
The new test drives the temperature-rejection path, which emits an ET_LOG (and
thus calls et_pal_current_ticks()) before any model load. The RunnerTest fixture
never initializes the ExecuTorch runtime, so the timer call aborts. The valid-
temperature tests in the same fixture pass because their happy path does not log.
Fix: initialize the runtime in RunnerTest::SetUp(), matching the established
pattern used by the sibling tests in this same directory (test_text_prefiller,
test_util, test_wav_loader all call executorch::runtime::runtime_init() in
SetUp()). Applied to both the fbcode and xplat copies.
Differential Revision: D108831322