fix: correct resize dimension order for non-square images#646
Open
CODING-DARSH wants to merge 1 commit into
Open
fix: correct resize dimension order for non-square images#646CODING-DARSH wants to merge 1 commit into
CODING-DARSH wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR fixes the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Fixes an issue in the image
Resizetransform where non-square dimensions were passed directly to Pillow without converting FastEmbed's internal(height, width)representation to Pillow's expected(width, height)format.The issue is currently masked because supported image models use square dimensions, but non-square image processor configurations produce swapped output sizes.
Changes
(height, width)to(width, height)before callingPIL.Image.resize.Validation
Added a regression test demonstrating the issue:
Resize(size=(100, 200))produced an image with size(100, 200).(200, 100).The regression test fails on the previous implementation and passes with this change.