make notifying merge planner best effort#6493
Closed
mattmkim wants to merge 6 commits into
Closed
Conversation
…couple-index-compaction' into matthew.kim/byoc-decouple-index-compaction
Collaborator
|
@mattmkim Nadav has been working on externalizing merging to dedicated nodes. This problem should disappear once shipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Indexing is coupled with merge planner pipeline availability - if we can't notify the merge planner, than indexing stops. For example, due to the pagination bug, indexing just stopped in one of the quickhouse org cluster.
For now, make the notification best effort. On restarts, we'll fetch all non merged files to compact. This kinda sucks, because restarts might not happen for a while, and depending on the merge policy, not sure if an old, uncompacted file will merge well. We're eventually moving towards a better/pull based model, with compaction as its own service.
How was this PR tested?
Describe how you tested this PR.