Skip to content

fix regex to detect manylinux as ppm binary repo#139

Merged
gaborcsardi merged 1 commit into
r-lib:mainfrom
AdaemmerP:fix-manylinux-detect
Jun 11, 2026
Merged

fix regex to detect manylinux as ppm binary repo#139
gaborcsardi merged 1 commit into
r-lib:mainfrom
AdaemmerP:fix-manylinux-detect

Conversation

@AdaemmerP

Copy link
Copy Markdown
Contributor

This pull request fixes the issues #883 in pak and #183. The problem is that pkgcache:::is_ppm_linux_repo_url() does not recognize manylinux as a binary download url.

@gaborcsardi

Copy link
Copy Markdown
Member

Superficial testing:

> options(repos = c(CRAN = "https://packagemanager.posit.co/cran/__linux__/manylinux_2_28/latest"))
> cmc <- cranlike_metadata_cache$new(bioc = FALSE)
> table(cmc$list()$platform)

aarch64-unknown-linux-gnu-ubuntu-24.04                                 source 
                                 22018                                   1921 

Ideally the platform would be manylinux, but we can improve that later.

@gaborcsardi gaborcsardi merged commit 3ae12e0 into r-lib:main Jun 11, 2026
21 of 23 checks passed
@gaborcsardi

Copy link
Copy Markdown
Member

Thank you!

gaborcsardi added a commit to r-lib/pak that referenced this pull request Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants