Skip to content

feat(invite): make org dropdown searchable and show title instead of name#1712

Merged
Shreyag02 merged 2 commits into
mainfrom
fix/invite-user-flow/org-name-mismatch
Jun 30, 2026
Merged

feat(invite): make org dropdown searchable and show title instead of name#1712
Shreyag02 merged 2 commits into
mainfrom
fix/invite-user-flow/org-name-mismatch

Conversation

@Shreyag02

@Shreyag02 Shreyag02 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Two related improvements to the admin "Invite user" organization dropdown:

  1. Searchable dropdown — with many organizations the plain dropdown was slow and error-prone to scan. It's now type-to-filter (matches on the org name as you type).
  2. Correct label — the dropdown rendered each org's URL slug (org.name) instead of its display title (org.title). Since the org list view and the invite email both use the title, the option didn't match what users saw elsewhere — selecting an org produced an invite email showing a different name.

Changes

  • Add autocomplete to the organization Select to enable type-to-filter search, with a searchPlaceholder on Select.Content for the
    search input.
  • Display org.title (falling back to org.name when title is unset) in the organization dropdown of the admin member-invite dialog.

Technical Details

In Frontier's org model, title is the human-readable display name while name is the URL slug / unique identifier. The invite dropdown in web/sdk/admin/views/users/list/invite-users.tsx was rendering org.name, whereas the org list (organizations/list/columns.tsx) and the invite email use org.title, causing the perceived mismatch. The submitted form value is still org.id, so the invite target is unaffected — only the visible label changed.

Search is powered by Apsara's Select autocomplete (default autocompleteMode="auto"); no mode prop is needed. Filtering matches against the rendered option label (org.title || org.name), so results match on the name users see.

Test Plan

  • Manual testing completed
    • Open admin → Users → Invite user; confirm the organization dropdown is searchable and the option labels match the names shown in the organization list.
    • Type a partial org name and confirm the list filters to matching organizations.
    • Send an invite and verify the org name in the received email matches the selected dropdown option.
  • Build and type checking passes

SQL Safety (if your PR touches *_repository.go or goqu.*)

N/A — frontend-only change; no *_repository.go or goqu.* files touched.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jun 30, 2026 9:43am

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 729b6d83-5f8d-4997-b9b5-7ae9f7207cec

📥 Commits

Reviewing files that changed from the base of the PR and between b36d8be and a88e9ec.

📒 Files selected for processing (1)
  • web/sdk/admin/views/users/list/invite-users.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/sdk/admin/views/users/list/invite-users.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved the organization selector in the user invite flow to display a more descriptive label when available, falling back to the prior value when not.
  • New Features
    • Added organization search support in the selector, including autocomplete and a contextual search placeholder.

Walkthrough

The invite-user organization dropdown now supports autocomplete search UI text and displays org.title when present, otherwise org.name.

Changes

Invite user organization label

Layer / File(s) Summary
Organization select label
web/sdk/admin/views/users/list/invite-users.tsx
The organization select adds autocomplete search UI text and renders org.title with fallback to org.name for each option.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28435152296

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.02%) to 43.789%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 72 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

72 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
pkg/server/connect_interceptors/authorization.go 72 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 37071
Covered Lines: 16233
Line Coverage: 43.79%
Coverage Strength: 12.38 hits per line

💛 - Coveralls

@Shreyag02 Shreyag02 requested a review from rohanchkrabrty June 30, 2026 05:46
Comment thread web/sdk/admin/views/users/list/invite-users.tsx Outdated
Comment thread web/sdk/admin/views/users/list/invite-users.tsx
@Shreyag02 Shreyag02 changed the title fix(invite): show org title instead of slug(org name) in member invite dropdown feat(invite): make org dropdown searchable and show title instead of name Jun 30, 2026
@Shreyag02 Shreyag02 requested a review from rohanchkrabrty June 30, 2026 09:48
@Shreyag02 Shreyag02 merged commit 5103b7f into main Jun 30, 2026
8 checks passed
@Shreyag02 Shreyag02 deleted the fix/invite-user-flow/org-name-mismatch branch June 30, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants