feat(invite): make org dropdown searchable and show title instead of name#1712
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe invite-user organization dropdown now supports autocomplete search UI text and displays ChangesInvite user organization label
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 28435152296Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.02%) to 43.789%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions72 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Summary
Two related improvements to the admin "Invite user" organization dropdown:
org.name) instead of its display title (org.title). Since the org list view and the invite email both use the title, the option didn't match what users saw elsewhere — selecting an org produced an invite email showing a different name.Changes
autocompleteto the organizationSelectto enable type-to-filter search, with asearchPlaceholderonSelect.Contentfor thesearch input.
org.title(falling back toorg.namewhen title is unset) in the organization dropdown of the admin member-invite dialog.Technical Details
In Frontier's org model,
titleis the human-readable display name whilenameis the URL slug / unique identifier. The invite dropdown inweb/sdk/admin/views/users/list/invite-users.tsxwas renderingorg.name, whereas the org list (organizations/list/columns.tsx) and the invite email useorg.title, causing the perceived mismatch. The submitted form value is stillorg.id, so the invite target is unaffected — only the visible label changed.Search is powered by Apsara's
Selectautocomplete (defaultautocompleteMode="auto"); no mode prop is needed. Filtering matches against the rendered option label (org.title || org.name), so results match on the name users see.Test Plan
SQL Safety (if your PR touches
*_repository.goorgoqu.*)N/A — frontend-only change; no
*_repository.goorgoqu.*files touched.