Skip to content

fix: auth OIDC button styles#1759

Merged
rohanchkrabrty merged 2 commits into
mainfrom
fix-auth-oidc-buttons
Jul 15, 2026
Merged

fix: auth OIDC button styles#1759
rohanchkrabrty merged 2 commits into
mainfrom
fix-auth-oidc-buttons

Conversation

@rohanchkrabrty

Copy link
Copy Markdown
Contributor

Summary

  • fixes sdk auth oidc button styles
image

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jul 15, 2026 4:35am

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 64bbf436-e5d4-42f9-87bd-5e8743274714

📥 Commits

Reviewing files that changed from the base of the PR and between afc1be7 and 99890af.

📒 Files selected for processing (2)
  • web/sdk/client/components/auth-oidc-button/auth-oidc-button.module.css
  • web/sdk/client/components/auth-oidc-button/auth-oidc-button.tsx
💤 Files with no reviewable changes (1)
  • web/sdk/client/components/auth-oidc-button/auth-oidc-button.module.css

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated OIDC sign-in buttons to display provider logos consistently alongside the “Continue with…” label.
    • Removed obsolete logo styling.

Walkthrough

The OIDC provider button now renders its logo through the Button component’s leadingIcon prop and places the provider label directly in the button. The unused Text import and obsolete .logo CSS rule were removed.

Changes

OIDC button

Layer / File(s) Summary
Button icon and label rendering
web/sdk/client/components/auth-oidc-button/auth-oidc-button.tsx, web/sdk/client/components/auth-oidc-button/auth-oidc-button.module.css
AuthOIDCButton passes the conditional provider logo through leadingIcon, renders “Continue with {provider}” as button children, removes the Text import, and deletes the unused .logo styling.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29389333071

Coverage remained the same at 45.203%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37690
Covered Lines: 17037
Line Coverage: 45.2%
Coverage Strength: 12.69 hits per line

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty merged commit a41e92d into main Jul 15, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-auth-oidc-buttons branch July 15, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants