added list deprecation feature that exist in backstage/community-plug…#3787
Draft
AdamBrez wants to merge 1 commit into
Draft
added list deprecation feature that exist in backstage/community-plug…#3787AdamBrez wants to merge 1 commit into
AdamBrez wants to merge 1 commit into
Conversation
…ins to rhdh-plugins
|
hopehadfield
requested changes
Jul 16, 2026
hopehadfield
left a comment
hopehadfield
left a comment
Member
There was a problem hiding this comment.
Script looks good to me, though it may be worthwhile to review the SonarCloud suggestions.
On top of this, can you also allow this to be enabled in the CI via a flag in bcp.json? You can see how it was done in community-plugins here. Additionally, it's good practice to document this new feature in the docs (specifically the Contributing guide.
Comment on lines
+2
to
+16
| /* | ||
| * Copyright The Backstage Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
Member
There was a problem hiding this comment.
This copyright can be removed. I would just add a comment referencing the workflow in community-plugins (like this one).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ins to rhdh-plugins
Hey, I just made a Pull Request!
✔️ Checklist