Skip to content

chore(codecov): expand ignores for wiring, locales, and demo packages (RHIDP-15513)#3791

Open
rostalan wants to merge 2 commits into
redhat-developer:mainfrom
rostalan:rhidp-15513-codecov-ignores
Open

chore(codecov): expand ignores for wiring, locales, and demo packages (RHIDP-15513)#3791
rostalan wants to merge 2 commits into
redhat-developer:mainfrom
rostalan:rhidp-15513-codecov-ignores

Conversation

@rostalan

@rostalan rostalan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Ignore demo packages/app|app-legacy|backend, generated code, and *-test helper plugins
  • Ignore package entry / NFS wiring (src/index.ts(x), plugin.ts, alpha.ts(x)), translations, test-utils, Router/Trans
  • Keep constants.ts ignore scoped to orchestrator frontend only
  • Sync component_management with overlay metadata (required when touching codecov.yml)

Notes on review feedback

  • component_management / intelligent-assistant: Not a product demotion. Overlay metadata still uses the lightspeed workspace path, so the generator cannot map intelligent-assistant into GA. Verified with scripts/generate-codecov-components.sh --check --overlay <overlay>. The workspace remains in flag_management. It will reappear in GA once overlays are renamed/updated.
  • **/src/index.tsx: Kept intentionally — those files are NFS/plugin wiring (same class as alpha.tsx / plugin.ts). Comment updated to say so; nested index.tsx under components stay counted.

Split from #3786 (codecov slice).

@rostalan
rostalan requested review from a team as code owners July 16, 2026 13:32
@rostalan

Copy link
Copy Markdown
Contributor Author

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 16, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:40 PM UTC · Completed 1:52 PM UTC
Commit: 26bd802 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — comment

The ignore-pattern changes are well-reasoned and improve coverage accuracy. The bug fix for the test-helper glob (workspaces/plugins/*-test/**workspaces/*/plugins/*-test/**) is correct — the old pattern never matched anything. Narrowing **/index.ts to **/src/index.ts correctly preserves coverage for nested index.ts files that contain real logic. The new boilerplate exclusions (translations, alpha wiring, plugin.ts, Router.tsx, Trans.tsx, generated code) are appropriately scoped and well-documented with inline comments. No security issues, no documentation staleness, and no style/convention violations were found.

One concern warrants attention before merge:

component_management manual edit (medium)

The component_management section is marked "GENERATED — do not edit by hand" and has a dedicated sync workflow (.github/workflows/sync-codecov-components.yml) and generation script (scripts/generate-codecov-components.sh). This PR manually removes workspaces/intelligent-assistant/ from the GA component list without regenerating via the script.

Concrete concerns:

  • The intelligent-assistant workspace still exists on disk with active plugins and source code, but now appears in no component list (not GA, not tech-preview, not community, not dev-preview). Its coverage data will still be collected via flag_management (line 170) but won't roll up into any component-level dashboard.
  • The manual edit may conflict with or be overwritten by the next automated sync run. If the overlay metadata has already changed, regenerating via scripts/generate-codecov-components.sh --write would produce the correct result and maintain process integrity.
  • This change is outside the scope of "expand ignores" — it is a workspace reclassification that should ideally follow the established automation path.

Suggestion: Consider splitting the component list change out of this PR and either (a) regenerating via the script if the overlay metadata has already been updated, or (b) deferring until the overlay change lands and triggers the automated sync.

**/src/index.tsx — net-new coverage exclusion (low)

The old config ignored **/index.ts but not **/index.tsx. The PR narrows the .ts exclusion (good) but also adds **/src/index.tsx as a net-new exclusion. At least two src/index.tsx files contain substantive plugin logic rather than simple barrel re-exports:

  • workspaces/intelligent-assistant/plugins/intelligent-assistant/src/index.tsx (209 lines: API factories, page blueprints, route refs, drawer configs)
  • workspaces/quickstart/plugins/quickstart/src/index.tsx (101 lines: plugin definition, drawer blueprint, init module)

The inline comment says "Package entry barrels only" but these files go beyond re-exports. Whether plugin wiring code should be covered is a judgment call, but the comment is slightly misleading about what these files contain.


Positive highlights:

  • The *-test glob fix catches a real bug that silently prevented test-helper exclusions
  • Comment annotations explaining the rationale for each pattern group are excellent
  • Scoping constants.ts to only workspaces/orchestrator/plugins/orchestrator/ (not -common packages) shows good discipline
  • The **/generated/** pattern correctly matches only auto-generated OpenAPI client code today

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Jul 16, 2026
rostalan and others added 2 commits July 20, 2026 10:11
Generalize coverage ignores for package entry barrels, locale catalogs,
test-utils, plugin/alpha wiring, Router/Trans wrappers, demo app/backend
hosts, and test-helper plugins. Keep orchestrator frontend constants.ts
scoped so *-common constant modules remain in the coverage denominator.

Co-authored-by: Cursor <cursoragent@cursor.com>
The ignore targets package entry / NFS plugin wiring modules, not every
index file. Nested index modules under api/components/services stay in
the coverage denominator. component_management remains script-synced
with overlay metadata (generate-codecov-components.sh --check passes).

Co-authored-by: Cursor <cursoragent@cursor.com>
@rostalan
rostalan force-pushed the rhidp-15513-codecov-ignores branch from d425ac0 to 17b5bcf Compare July 20, 2026 08:11
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants