chore(codecov): expand ignores for wiring, locales, and demo packages (RHIDP-15513)#3791
chore(codecov): expand ignores for wiring, locales, and demo packages (RHIDP-15513)#3791rostalan wants to merge 2 commits into
Conversation
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 1:40 PM UTC · Completed 1:52 PM UTC |
Review — commentThe ignore-pattern changes are well-reasoned and improve coverage accuracy. The bug fix for the test-helper glob ( One concern warrants attention before merge:
|
Generalize coverage ignores for package entry barrels, locale catalogs, test-utils, plugin/alpha wiring, Router/Trans wrappers, demo app/backend hosts, and test-helper plugins. Keep orchestrator frontend constants.ts scoped so *-common constant modules remain in the coverage denominator. Co-authored-by: Cursor <cursoragent@cursor.com>
The ignore targets package entry / NFS plugin wiring modules, not every index file. Nested index modules under api/components/services stay in the coverage denominator. component_management remains script-synced with overlay metadata (generate-codecov-components.sh --check passes). Co-authored-by: Cursor <cursoragent@cursor.com>
d425ac0 to
17b5bcf
Compare
|



Changes
packages/app|app-legacy|backend, generated code, and*-testhelper pluginssrc/index.ts(x),plugin.ts,alpha.ts(x)), translations, test-utils, Router/Transconstants.tsignore scoped to orchestrator frontend onlycomponent_managementwith overlay metadata (required when touchingcodecov.yml)Notes on review feedback
component_management/ intelligent-assistant: Not a product demotion. Overlay metadata still uses thelightspeedworkspace path, so the generator cannot mapintelligent-assistantinto GA. Verified withscripts/generate-codecov-components.sh --check --overlay <overlay>. The workspace remains inflag_management. It will reappear in GA once overlays are renamed/updated.**/src/index.tsx: Kept intentionally — those files are NFS/plugin wiring (same class asalpha.tsx/plugin.ts). Comment updated to say so; nestedindex.tsxunder components stay counted.Split from #3786 (codecov slice).