[WIP] test(e2e): reuse one runtime per worker + shared readiness helper (Tier 2)

web-local/tests/utils/wait-for-reconciliation.ts → web-common/tests/utils/wait-for-reconciliation.ts

@@ -74,3 +74,18 @@ export async function waitForReconciliation(page: Page, timeoutMs = 60_000) {
 
   return dataResources;
 }
+
+/**
+ * Navigates to a URL that depends on freshly created or edited resources, then
+ * waits for the project to finish reconciling before returning. Use this in
+ * place of a bare `page.goto(...)` whenever the destination needs resources to
+ * be ready (the recurring cause of navigate-before-reconcile flakiness).
+ */
+export async function gotoWhenReady(
+  page: Page,
+  url: string,
+  timeoutMs = 60_000,
+) {
+  await page.goto(url);
+  await waitForReconciliation(page, timeoutMs);
+}

web-local/tests/connectors/clickhouse-connector.spec.ts

@@ -27,6 +27,11 @@ test.describe("ClickHouse connector", () => {
   });
 
   test.describe("Welcome screen", () => {
+    // The welcome flow needs an uninitialized project, so use a pristine
+    // instance rather than the shared per-worker runtime (which keeps a
+    // rill.yaml present). The Home page block below stays on the shared runtime.
+    test.use({ freshInstance: true });
+
     test("Create connector using individual fields", async ({ page }) => {
       // Open the connect to clickhouse modal
       await page.getByLabel("Connect to clickhouse").click();

web-local/tests/connectors/motherduck-connector.spec.ts

@@ -3,8 +3,10 @@ import { test } from "../setup/base";
 import { updateCodeEditor } from "../utils/commonHelpers";
 
 test.describe("MotherDuck welcome flow", () => {
-  // Start from an empty workspace to exercise the onboarding path
-  test.use({ project: undefined });
+  // Start from an empty workspace to exercise the onboarding path. The welcome
+  // flow needs an uninitialized project, so use a pristine instance rather than
+  // the shared per-worker runtime (which keeps a rill.yaml present).
+  test.use({ project: undefined, freshInstance: true });
 
   test("initializes MotherDuck from welcome screen and persists secrets before connector", async ({
     page,

web-local/tests/connectors/postgres-connector.spec.ts

@@ -25,6 +25,11 @@ test.describe.skip("Postgres connector", () => {
   });
 
   test.describe("Welcome screen", () => {
+    // The welcome flow needs an uninitialized project, so use a pristine
+    // instance rather than the shared per-worker runtime. The Home page block
+    // below stays on the shared runtime.
+    test.use({ freshInstance: true });
+
     test("Create connector using individual fields", async ({ page }) => {
       await page.getByLabel("See more connectors").click();
       await enterPostgresCredentials(page, postgresOne);

web-local/tests/explores/annotations.spec.ts

@@ -4,7 +4,7 @@ import { V1TimeGrain } from "@rilldata/web-common/runtime-client/gen/index.schem
 import { interactWithTimeRangeMenu } from "@rilldata/web-common/tests/utils/explore-interactions";
 import { DateTime } from "luxon";
 import { test } from "../setup/base";
-import { waitForReconciliation } from "../utils/wait-for-reconciliation";
+import { waitForReconciliation } from "@rilldata/web-common/tests/utils/wait-for-reconciliation";
 
 // Annotation timestamps as they'll be serialized from DuckDB (UTC).
 // All annotations that may be visible at day grain in "Last 7 days":

web-local/tests/explores/open-query.spec.ts

@@ -1,5 +1,5 @@
 import { test } from "../setup/base";
-import { waitForReconciliation } from "../utils/wait-for-reconciliation.ts";
+import { waitForReconciliation } from "@rilldata/web-common/tests/utils/wait-for-reconciliation";
 
 test.describe("Query-to-Explore routing", () => {
   test.use({ project: "AdBids" });

web-local/tests/explores/time-grain-derivation.spec.ts

@@ -1,6 +1,6 @@
 import { expect, type Page } from "@playwright/test";
 import { test } from "../setup/base";
-import { waitForReconciliation } from "../utils/wait-for-reconciliation.ts";
+import { waitForReconciliation } from "@rilldata/web-common/tests/utils/wait-for-reconciliation";
 
 test.describe("Time grain derivation from URL", () => {
   test.use({ project: "AdBids" });

web-local/tests/explores/visual-explore-editing.spec.ts

@@ -1,6 +1,6 @@
 import { expect } from "@playwright/test";
 import { test } from "../setup/base";
-import { waitForReconciliation } from "../utils/wait-for-reconciliation";
+import { waitForReconciliation } from "@rilldata/web-common/tests/utils/wait-for-reconciliation";
 import { gotoNavEntry } from "../utils/waitHelpers";
 
 test.describe("visual explore editing", () => {

web-local/tests/init.spec.ts

@@ -2,7 +2,12 @@ import { EXAMPLES } from "@rilldata/web-common/features/welcome/constants";
 import { expect } from "playwright/test";
 import { test } from "./setup/base";
 import { splitFolderAndFileName } from "@rilldata/web-common/features/entity-management/file-path-utils.ts";
-import { waitForReconciliation } from "./utils/wait-for-reconciliation";
+import { waitForReconciliation } from "@rilldata/web-common/tests/utils/wait-for-reconciliation";
+
+// These tests drive the welcome / project-initialization flow, which only
+// appears for an uninitialized project. The shared per-worker runtime always
+// keeps a rill.yaml present, so these need their own pristine instance.
+test.use({ freshInstance: true });
 
 test.describe("Example project initialization", () => {
   EXAMPLES.forEach((example) => {

web-local/tests/rill-yaml.spec.ts

@@ -13,6 +13,10 @@ async function expectRillYAMLToContainOlapConnector(page: Page, text: string) {
 }
 
 test.describe("Default olap_connector behavior", () => {
+  // Exercises the empty/uninitialized project flow, which needs a pristine
+  // instance rather than the shared per-worker runtime (which keeps a rill.yaml).
+  test.use({ freshInstance: true });
+
   test("Should set default olap_connector to duckdb for empty project", async ({
     page,
   }) => {