Gil management#1
Merged
Merged
Conversation
ThreadSafetyTest (3 tests): concurrent exec, concurrent invokeFunction, and callbacks during concurrent access. These crashed the JVM (SIGABRT) before the fix. LibPython: add PyEval_SaveThread, PyGILState_Ensure, PyGILState_Release bindings (all Stable ABI since Python 3.2). Remove dead PyErr_Fetch. PythonEngine: release GIL after initialization via PyEval_SaveThread. Wrap exec(), invokeFunction() (both overloads) with GILState ensure/ release. close() acquires GIL but does not release after Py_FinalizeEx (finalization invalidates all thread states). FunctionDispatcher unchanged (GIL already held by CPython during callbacks). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add virtualThreadsInvokeFunction test (8 virtual threads) - Add mixedPlatformAndVirtualThreads test (2 platform + 4 virtual) - All 5 thread safety tests pass: GIL ensure/release pins virtual threads to their carrier during native calls automatically - Document thread safety in README Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.