bitreq: Fix connection persistence, pool refresh#661
Open
tnull wants to merge 5 commits into
Open
Conversation
Exercise the HTTP/1.1 wire grammar so request generation and response parsing gaps are visible before behavior is changed. Co-Authored-By: HAL 9000
Cover response length and chunk decoding rules so incomplete or ambiguous messages cannot pass unnoticed. Co-Authored-By: HAL 9000
Cover persistence, closure, and pipelining rules so connection reuse can be corrected against explicit expectations. Refs: rust-bitcoin#659 Co-Authored-By: HAL 9000
Reuse HTTP/1.1 connections unless either endpoint requests closure, and require explicit keep-alive only for HTTP/1.0. This allows compliant servers to omit redundant keep-alive headers while still preventing reuse after a close option. Fixes rust-bitcoin#659 Co-Authored-By: HAL 9000
A cache hit must make its connection the most recently used entry. Without that refresh, inserting another origin can evict an actively reused connection and retain an older idle one. Co-Authored-By: HAL 9000
c9845ce to
b925c3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #660.
Closes #659.