Skip to content

implement va_start and va_arg#906

Merged
antoyo merged 3 commits into
rust-lang:masterfrom
folkertdev:va-arg
Jul 14, 2026
Merged

implement va_start and va_arg#906
antoyo merged 3 commits into
rust-lang:masterfrom
folkertdev:va-arg

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

Comment thread tests/run/variadic.rs Outdated

@antoyo antoyo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!
One question:

View changes since this review

Comment thread src/intrinsic/mod.rs
Comment thread Cargo.toml Outdated
@antoyo

antoyo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I published a new version of both gccjit and gccjit_sys.

You will also need to update the commit in this file. This file contains the hash from GCC, not gccjit.rs.

@antoyo

antoyo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I'll rebuild the m68k GCC.
I'll also try to check if there's something wrong with the GCC version without int128.

@folkertdev folkertdev force-pushed the va-arg branch 2 times, most recently from 057a5dc to e571288 Compare July 14, 2026 14:50
@folkertdev

Copy link
Copy Markdown
Contributor Author

I've removed the test file, so I'll leave it to you to make CI pass.

@antoyo

antoyo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

The m68k CI is fixed, but the stdarch tests are still failing.
I did a rerun from the master and it passes, so there might be something in this PR that breaks the stdarch tests.

I opened a test PR to run the stdarch tests another time: let's see if the tests pass there.

Edit: The stdarch CI uses the pinned GCC, so maybe this is caused by the GCC update.

@antoyo

antoyo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I finished the sync and the stdarch tests now pass.
Could you please rebase this PR to get this fix?

@rustbot

This comment has been minimized.

@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev

Copy link
Copy Markdown
Contributor Author

All green now!

@antoyo antoyo merged commit 2467b67 into rust-lang:master Jul 14, 2026
40 checks passed
@antoyo

antoyo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Thanks a lot for this contribution!

Did you want me to send the GCC patch upstream (to the forge) or do you want to do it yourself?

@folkertdev

Copy link
Copy Markdown
Contributor Author

No if you can handle that that would be great

@antoyo

antoyo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Ok. I'll send this patch in the following weeks.

This was referenced Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants