fix(bootstrap): rename apt keyring to .gpg, drop SHA1/MD5, remove dead md5sum code#2121
Merged
Merged
Conversation
…d md5sum code apt only recognizes .gpg (binary) or .asc (armored) keyring extensions; salt-archive-keyring.pgp was silently ignored, causing NO_PUBKEY/unsigned repository failures on newer apt (saltstack/salt#69740). Rename the keyring bootstrap writes to .gpg and rewrite the fetched salt.sources Signed-By line to match, so this fix doesn't depend on salt-install-guide's release timing. Also remove SHA1 and MD5 as selectable Get-FileHash algorithms in the PowerShell scripts, and delete the unused md5sum-based __fetch_verify() function from bootstrap-salt.sh. Add a regression test asserting the apt keyring is trusted and apt-get update succeeds without NO_PUBKEY/unsupported-filetype errors.
salt-3006.8-0.x86_64.rpm consistently returns HTTP 400 from packages.broadcom.com (Artifactory filtered-resources lexical error on a NUL byte), breaking every RPM-based stable-3006-8 CI job. 3006.24 was verified to download successfully across all repos (rpm x86_64/aarch64, deb, onedir, windows, macos) - note macOS has no builds at all for 3006.15-3006.23, so 3006.23 would have silently broken macOS CI. Updated the generate.py template (source of truth) and regenerated ci.yml via the actual generator rather than hand-editing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
apt only recognizes .gpg (binary) or .asc (armored) keyring extensions; salt-archive-keyring.pgp was silently ignored, causing NO_PUBKEY/unsigned repository failures on newer apt (saltstack/salt#69740). Rename the keyring bootstrap writes to .gpg and rewrite the fetched salt.sources Signed-By line to match, so this fix doesn't depend on salt-install-guide's release timing.
Also remove SHA1 and MD5 as selectable Get-FileHash algorithms in the PowerShell scripts, and delete the unused md5sum-based __fetch_verify() function from bootstrap-salt.sh.
Add a regression test asserting the apt keyring is trusted and apt-get update succeeds without NO_PUBKEY/unsupported-filetype errors.
What issues does this PR fix or reference?
saltstack/salt#69740