[DX-4426] Fix Flaky TestScripts

[kalverra]

TestScripts is one of the most flaky areas in /chainlink. I ran the fix-flaky-tests skill on it with opus 4.8. It cost ~$2.00 and took ~30 minutes (excluding time to run the tests over and over to verify fixes).

Changes

• Potentially Breaking!!: StartUpHealthReport now returns 503 errors for non /health paths instead of the old 404 error. This is more in line with what most clients expect for this sort of situation. curl --retry is used in TestScripts to keep calling these endpoints until they're ready, but it will not retry if it gets a 404.
• Added tests for tools/txtar/visitor.go and updated it with some more modern Go patterns, should help performance a teeny-tiny bit.

Results

# Before
❯ make test ARGS="diagnose --iterations 100 -- -run TestScripts ."
   Estimated flake rate = 1.6% - 4.2%

# After
❯ make test ARGS="diagnose --iterations 600 -- -run TestScripts ."
   Estimated flake rate = 0% - 0.6%

[github-actions]

👋 kalverra, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[github-actions]

CORA - Analysis Skipped

Reason: The number of code owners (2) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (1) is less than the minimum required (2).

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube