feat(input): list block types + marker rendering (lists 2/5)#511
Open
wildseansy wants to merge 2 commits into
Open
feat(input): list block types + marker rendering (lists 2/5)#511wildseansy wants to merge 2 commits into
wildseansy wants to merge 2 commits into
Conversation
Introduces BlockType.ANCHORED (Android) and ENRMBlockTypePersistsWhenEmpty (iOS) and routes the block store's adjust/normalize passes, the formatter's zero-length anchor stamping, and the views' orphan-anchor prune through them instead of heading-only checks. No behavior change — headings are the only anchored type until the list block type lands on top. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
UNORDERED_LIST_ITEM and ORDERED_LIST_ITEM with 0-based nesting depth in the range's level payload, joined to the anchored-type set. The store's list-metadata pass clamps depths to valid ancestry (an item nests at most one level under the previous adjacent item, so every state serializes) and computes each ordered item's 1-based ordinal from its position among adjacent same-depth, same-type siblings. One handler instance per type: Android renders via LeadingMarginSpans (bullet dot/ring/square by depth; right-aligned number for ordered) plus a LineHeightSpan for spacing; iOS reserves the indent column via the paragraph style and draws the glyph or number in the layout manager, with the ordinal stamped as a text attribute. listItemSpacing prop spaces items on both platforms. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list stack (per the review ask, now including ordered lists — the shared machinery made them cheap to add):
GitHub can't base a fork PR on another fork branch, so every PR targets
mainand the diff shown for PR N is cumulative — this PR's own change is its last commit (each stage is exactly one commit on the previous branch). We'll merge bottom-up; after each merge the next PR's diff collapses to just its own commit. Checkoutfeat/list-5-stateto test the full feature end-to-end.This PR (last commit)
UNORDERED_LIST_ITEM/ORDERED_LIST_ITEMwith 0-based nesting depth in the range'slevelpayload, joined to the anchored-type set. The store's list-metadata pass clamps depths to valid ancestry (an item nests at most one level under the previous adjacent item — CommonMark cannot represent orphan nesting, so every editor state serializes losslessly) and computes each ordered item's 1-based ordinal from its position among adjacent same-depth, same-type siblings — numbering stays correct as items are added, removed, or re-nested.Rendering: Android draws markers via
LeadingMarginSpans (dot/ring/square by depth for bullets, right-alignedN.for ordered) plus aLineHeightSpanfor the newlistItemSpacingprop; iOS reserves the indent column via the paragraph style and draws the glyph/number in the layout manager, reading the ordinal from a stamped text attribute. One handler instance per type serves every depth, mirroring the heading handler.The layout manager's empty-line marker API is exercised by the orchestrator in #513.
🤖 Generated with Claude Code