Skip to content

Upgrade Core to e586f557af367c74d08d2818bc4bd0d07c8b20bc#917

Merged
jviotti merged 1 commit into
mainfrom
no-python
May 28, 2026
Merged

Upgrade Core to e586f557af367c74d08d2818bc4bd0d07c8b20bc#917
jviotti merged 1 commit into
mainfrom
no-python

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 28, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 28, 2026

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core dependency to e586f557af367c74d08d2818bc4bd0d07c8b20bc, bringing in new build hardening defaults and migrating Unicode/IDNA table generation away from Python.

Changes:

  • Bumps the core revision in DEPENDENCIES.
  • Adds additional compiler/linker hardening flags (e.g. MSVC CFG/CET and GCC/Clang stack-clash protection) and refines PIE handling.
  • Replaces Python-based IDNA and Unicode UCD code generators with C++ codegen executables driven by custom build commands.
  • Introduces reusable helpers in core for line iteration (for_each_line), text splitting/trim/join, and additional numeric parsing (to_uint32_t).
  • Refactors UCD/IDNA enums to be generated from macro lists shared with the code generators.
  • Fixes an edge-case loop termination in regex set-ops preprocessing.

Technical Notes: The new code generators depend on the updated core text/numeric/io utilities, and the build system now builds and runs those generators as part of producing the generated headers.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

OUTPUT "${SOURCEMETA_CORE_IDNA_DATA_HEADER}"
COMMAND "${Python3_EXECUTABLE}"
"${CMAKE_CURRENT_SOURCE_DIR}/codegen.py"
COMMAND "${SOURCEMETA_CORE_IDNA_CODEGEN_TARGET}"
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In vendor/core/src/core/idna/CMakeLists.txt:18, sourcemeta_executable(OUTPUT ...) sets SOURCEMETA_CORE_IDNA_CODEGEN_TARGET to the target name (see vendor/core/cmake/common/targets/executable.cmake:27-29), but add_custom_command(COMMAND ...)typically needs the actual executable path (e.g. via$<TARGET_FILE:...>); using the raw target name can make the build fail when the binary isn’t on PATH` (notably with multi-config generators).

Severity: high

Other Locations
  • vendor/core/src/core/unicode/CMakeLists.txt:18

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti merged commit 40293a1 into main May 28, 2026
14 checks passed
@jviotti jviotti deleted the no-python branch May 28, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant