refactor: rename Galileo OTel symbols to Splunk AO (GalileoSpan, galileo-tracer, galileo-otel)#90
refactor: rename Galileo OTel symbols to Splunk AO (GalileoSpan, galileo-tracer, galileo-otel)#90adityamehra wants to merge 3 commits into
Conversation
…_span, galileo-otel → splunk-ao-otel Remove remaining Galileo branding from the OTel integration layer: - Import alias: `Span as GalileoSpan` → `Span as SplunkAOSpan` - Parameter/variable names: `galileo_span` → `splunk_ao_span` across otel.py, handler.py, and utils - gen_ai.system attribute value: `"galileo-otel"` → `"splunk-ao-otel"` - Test class/method names updated to match - Examples updated: start_galileo_span → start_splunk_ao_span, galileo_span_processor → splunk_ao_span_processor Co-authored-by: Cursor <cursoragent@cursor.com>
fercor-cisco
left a comment
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Clean mechanical rename; only two minor leftover branding references remain, no correctness impact.
| if tracer_provider is None: | ||
| tracer_provider = trace.get_tracer_provider() | ||
| _TRACE_PROVIDER_CONTEXT_VAR.set(cast(TracerProvider, tracer_provider)) | ||
| tracer = tracer_provider.get_tracer("galileo-tracer") |
There was a problem hiding this comment.
🟡 minor (other): The OTel tracer/instrumentation-scope name is still "galileo-tracer". This string is emitted in every span's scope metadata, so it's user-visible telemetry branding — the same kind of leftover as the gen_ai.system value you did rename to "splunk-ao-otel" two lines below. Since the PR's stated goal is to replace all remaining Galileo branding in the OTel integration layer, this appears to be an in-scope miss. Note that changing it is a behavioral change for any downstream consumer filtering spans by scope name, so confirm that's intended before flipping it.
| tracer = tracer_provider.get_tracer("galileo-tracer") | |
| tracer = tracer_provider.get_tracer("splunk-ao-tracer") |
🤖 Generated by the Astra agent
| @staticmethod | ||
| def add_splunk_ao_custom_span(span: GalileoSpan) -> Span[SplunkAOCustomSpan]: | ||
| def add_splunk_ao_custom_span(span: SplunkAOSpan) -> Span[SplunkAOCustomSpan]: | ||
| """Add a Galileo custom span to the trace.""" |
There was a problem hiding this comment.
🔵 nit (documentation): Docstring still reads "Add a Galileo custom span to the trace." — another leftover Galileo branding reference the rename missed.
| """Add a Galileo custom span to the trace.""" | |
| """Add a Splunk AO custom span to the trace.""" |
🤖 Generated by the Astra agent
|
@adityamehra there seem to be a couple leftovers to rename. |
- "galileo-tracer" → "splunk-ao-tracer" (OTel instrumentation scope name) - "Add a Galileo custom span" → "Add a Splunk AO custom span" (docstring) Addresses review comments from fercor-cisco on PR #90. Co-authored-by: Cursor <cursoragent@cursor.com>
Documents the changes made in this branch for users who depend on OTel span attributes (gen_ai.system, otel.scope.name) and for internal contributors reviewing the refactor. Covers: instrumentation scope name, gen_ai.system value, import alias, parameter renames, and example variable name updates. Co-authored-by: Cursor <cursoragent@cursor.com>
adityamehra
changed the title
2 participants
Summary
Removes remaining
galileobranding from the OpenTelemetry integration layer. This is a clean-up follow-on to HYBIM-832.GalileoSpan→SplunkAOSpan— import alias inotel.py,handler.py, andutils/openai_agents.py"galileo-tracer"→"splunk-ao-tracer"— OTel instrumentation scope name (appears asotel.scope.namein exported traces)"galileo-otel"→"splunk-ao-otel"—gen_ai.systemattribute value set on every span emitted bystart_splunk_ao_span()galileo_span→splunk_ao_span— internal parameter names inotel.pyhelper functionsgalileo_span_processor→splunk_ao_span_processor,start_galileo_span→start_splunk_ao_span)handler.py(Add a Galileo custom span→Add a Splunk AO custom span)docs/OTEL_GALILEO_TO_SPLUNK_AO_RENAME.mddetailing all changes, OTel attribute impact, and migration notesFiles Changed
src/splunk_ao/otel.pygen_ai.systemvaluesrc/splunk_ao/handlers/openai_agents/handler.pysrc/splunk_ao/utils/openai_agents.pyexamples/agent/google-adk/my_agent/agent.pyexamples/agent/langgraph-open-telemetry/main.pyexamples/rag/cli-rag-demo/python-service/app.pytests/test_otel.pytests/test_openai_agents_utils.pydocs/OTEL_GALILEO_TO_SPLUNK_AO_RENAME.mdBreaking Changes
The public Python API (
start_splunk_ao_span,add_splunk_ao_span_processor,SplunkAOSpanProcessor) is unchanged.Users who filter on OTel span attributes should update:
gen_ai.systemgalileo-otelsplunk-ao-otelotel.scope.namegalileo-tracersplunk-ao-tracerTest Plan
tests/test_otel.py— all tests updated and passingtests/test_openai_agents_utils.py— updated and passingRelated