Validate stable driver publication before upload#14
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
86e1c97 to
3cde172
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cde1720aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -euo pipefail | ||
| test -n "${FTW_DRIVER_BETA_MANIFEST:-}" | ||
| test -n "${FTW_DRIVER_BETA_DIR:-}" | ||
| test -n "${FTW_DRIVER_PREVIOUS_MANIFEST:-}" |
There was a problem hiding this comment.
Handle first stable promotions without a previous manifest
For a stable run where drivers-stable has not been created yet, the earlier history download step leaves FTW_DRIVER_PREVIOUS_MANIFEST unset, so this test -n exits before the later Create channel release when missing step can create the stable release. That makes the first stable promotion of a beta-tested commit impossible even though the workflow still has a missing-release path; allow an empty previous-stable baseline or move creation/bootstrapping ahead of this gate.
Useful? React with 👍 / 👎.
Summary
Closes #12.
Tests
Coordination
GoodWe #13 has no direct file overlap. This branch does not change drivers, catalog data, channel refs or release assets, and it does not alter the #13 branch.