fix(pixii): skip optional meter energy scale factor when absent#16
Merged
Merged
Conversation
Some PowerShaper firmware returns Illegal Data Address on register 40288. Probe once during driver_init and avoid polling it so FTW's fresh Modbus read evidence does not fail the whole driver. Fixes srcfl#15 Signed-off-by: Tommy Lindgren <tommy@lindgrens.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PowerShaper firmware returns Illegal Data Address on register
40288. Probe once during driver_init and avoid polling it so FTW's
fresh Modbus read evidence does not fail the whole driver.
Fixes #15
Summary
Pixii catalog driver (
1.1.1) and FTW v2 package target (1.2.2) now probemeter-energy scale factor register 40288 once during
driver_initand skip itduring
driver_pollwhen absent. This prevents FTW's poll-scoped Modbusevidence from failing the whole driver when one optional register is missing.
Driver evidence
pixiimeter_energy_sf, absolute 40288); Pixii Modbus mapping doc 13300drivers/pixii.lua1.2.0 with same init-probe workaround):pixii-1recovered fromdriver_poll: 1 of 37 modbus reads failed/ offline tostatus: ok,consecutive_errors: 0make test-driver ID=pixii,make package-driver ID=pixii TARGET=ftw-core,make check— all passed locallysf=0; on tested working unit 40288 also reads 0, so behaviour matchesmeter_wand phase readings are unaffectedSafety
Package or promotion evidence
com.sourceful.driver.pixii1.2.2ftw-core(catalog 1.1.1 + package candidate 1.2.2)make package-driver ID=pixii TARGET=ftw-coreoutput at commit timerequired: not applicable for this read-path bugfix; existing package HIL gates unchangedfalseChecks
Signed-off-by.make test-driver ID=pixiimake package-driver ID=pixii TARGET=ftw-coremake check