fix(client): scope credential cache by coordinator#230
Open
YuMo12268 wants to merge 2 commits into
Open
Conversation
| Alternatively, they can directly specify their username (`-u`) or password (`-p`) during execution. | ||
| Once authenticated, the Client will retain their credentials in a file for future use. | ||
| Cached credentials are scoped by both the Coordinator address and username, so credentials for the same username on different Coordinators can coexist in the same credential file. | ||
| Credential entries written by previous versions do not contain a Coordinator address and are ignored, so users may need to log in again after upgrading. |
There was a problem hiding this comment.
This information doesn't have to be included in the guide. The user doesn't need to know how we store the credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --allcargo clippy --workspacecargo clippy --workspace --all-features -- -D warningscargo buildcargo test --workspacecargo doccd guide && mdbook buildusername:tokenentries are ignored without panic;coordinator_addr,username, andtoken;Notes
cargo auditreports existing dependency advisories unrelated to this change.