📂 Change base dir from meeting-notes to just meetings#2390
Conversation
There was a problem hiding this comment.
Pull request overview
Renames the Docusaurus “meeting notes” blog base directory to meetings to match the production slug and align with the repo’s single-word folder naming, updating build/tooling paths and adding redirects to preserve old URLs.
Changes:
- Update Docusaurus blog config to use
meetingsas the blog path. - Update formatting (Prettier) and translation (Crowdin) globs to target
meetings. - Add Nginx redirects from
/meeting-notesto/meetings, and move meeting content intomeetings/.
Reviewed changes
Copilot reviewed 4 out of 70 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Update Prettier scripts to format/check MD/MDX under meetings/ instead of meeting-notes/. |
| nginx/includes/redirects.conf | Add permanent redirects from legacy /meeting-notes routes to /meetings. |
| docusaurus.config.ts | Change Docusaurus blog path to meetings (route remains /meetings). |
| crowdin.yaml | Update translation source path from /meeting-notes/**/* to /meetings/**/*. |
| meetings/authors.yml | Add/relocate blog authors metadata under the new meetings/ directory. |
| meetings/2024-01-18.mdx | Meeting post under meetings/. |
| meetings/2024-01-26.mdx | Meeting post under meetings/. |
| meetings/2024-02-01.mdx | Meeting post under meetings/. |
| meetings/2024-02-09.mdx | Meeting post under meetings/. |
| meetings/2024-02-15.mdx | Meeting post under meetings/. |
| meetings/2024-02-22.mdx | Meeting post under meetings/. |
| meetings/2024-02-29.mdx | Meeting post under meetings/. |
| meetings/2024-03-07.mdx | Meeting post under meetings/. |
| meetings/2024-03-14.mdx | Meeting post under meetings/. |
| meetings/2024-03-21.mdx | Meeting post under meetings/. |
| meetings/2024-03-28.mdx | Meeting post under meetings/. |
| meetings/2024-04-04.mdx | Meeting post under meetings/. |
| meetings/2024-04-11.mdx | Meeting post under meetings/. |
| meetings/2024-04-18.mdx | Meeting post under meetings/. |
| meetings/2024-04-25.mdx | Meeting post under meetings/. |
| meetings/2024-05-02.mdx | Meeting post under meetings/. |
| meetings/2024-05-09.mdx | Meeting post under meetings/. |
| meetings/2024-06-13.mdx | Meeting post under meetings/. |
| meetings/2024-06-20.mdx | Meeting post under meetings/. |
| meetings/2024-06-27.mdx | Meeting post under meetings/. |
| meetings/2024-07-11.mdx | Meeting post under meetings/. |
| meetings/2024-07-18.mdx | Meeting post under meetings/. |
| meetings/2024-07-25.mdx | Meeting post under meetings/. |
| meetings/2024-08-01.mdx | Meeting post under meetings/. |
| meetings/2024-08-08.mdx | Meeting post under meetings/. |
| meetings/2024-08-15.mdx | Meeting post under meetings/. |
| meetings/2024-08-22.mdx | Meeting post under meetings/. |
| meetings/2024-08-29.mdx | Meeting post under meetings/. |
| meetings/2024-09-05.mdx | Meeting post under meetings/. |
| meetings/2024-09-12.mdx | Meeting post under meetings/. |
| meetings/2024-09-19.mdx | Meeting post under meetings/. |
| meetings/2024-09-26.mdx | Meeting post under meetings/. |
| meetings/2024-10-24.mdx | Meeting post under meetings/. |
| meetings/2024-11-14.mdx | Meeting post under meetings/. |
| meetings/2024-12-05.mdx | Meeting post under meetings/. |
| meetings/2024-12-12.mdx | Meeting post under meetings/. |
| meetings/2024-12-19.mdx | Meeting post under meetings/. |
| meetings/2025-01-16.mdx | Meeting post under meetings/. |
| meetings/2025-01-23.mdx | Meeting post under meetings/. |
| meetings/2025-01-30.mdx | Meeting post under meetings/. |
| meetings/2025-02-06.mdx | Meeting post under meetings/. |
| meetings/2025-02-13.mdx | Meeting post under meetings/. |
| meetings/2025-02-20.mdx | Meeting post under meetings/. |
| meetings/2025-02-27.mdx | Meeting post under meetings/. |
| meetings/2025-03-06.mdx | Meeting post under meetings/. |
| meetings/2025-03-27.mdx | Meeting post under meetings/. |
| meetings/2025-04-03.mdx | Meeting post under meetings/. |
| meetings/2025-04-10.mdx | Meeting post under meetings/. |
| meetings/2025-04-17.mdx | Meeting post under meetings/. |
| meetings/2025-05-01.mdx | Meeting post under meetings/. |
| meetings/2025-05-22.mdx | Meeting post under meetings/. |
| meetings/2025-07-10.mdx | Meeting post under meetings/. |
| meetings/2025-07-17.mdx | Meeting post under meetings/. |
| meetings/2025-07-24.mdx | Meeting post under meetings/. |
| meetings/2025-08-07.mdx | Meeting post under meetings/. |
| meetings/2025-09-25.mdx | Meeting post under meetings/. |
| meetings/2025-10-02.mdx | Meeting post under meetings/. |
| meetings/2025-10-09.mdx | Meeting post under meetings/. |
| meetings/2025-10-16.mdx | Meeting post under meetings/. |
| meetings/2025-10-23.mdx | Meeting post under meetings/. |
| meetings/2025-10-30.mdx | Meeting post under meetings/. |
| meetings/2025-11-06.mdx | Meeting post under meetings/. |
| meetings/2026-01-22.mdx | Meeting post under meetings/. |
| meetings/2026-01-29.mdx | Meeting post under meetings/. |
| meetings/2026-02-26.mdx | Meeting post under meetings/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kaankacar
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Agree on the convention.
One thing on the nginx rewrites:
routeBasePath: 'meetings' has been set since the blog was first introduced — see 8abb6525(#449, April 2024). The path and routeBasePath have just been mismatched on disk all along; the URL has always been /meetings/... publicly. So /meeting-notes/... was never a live URL. There's nothing for those redirects to catch.
Unless I'm missing a case where one of those paths actually resolved, I'd drop both rules rather than land permanent rewrites for paths that never existed.
Otherwise LGTM!
I forgot to migrate this from 16e1e75. Those paths are cited in the Discord and other external media for the old Soroban docs domains. Examples: - https://discord.com/channels/897514728459468821/911254664576643122/1205535765639995402 (as https://soroban.stellar.org/docs/notes#2024-02-09) and - https://discord.com/channels/897514728459468821/1199121845656486009/1202029981564416050 (as https://soroban.stellar.org/docs/notes#2024-01-26)
|
Thank you for the comment. It reminded me that I missed an edge case from the original branch. Fixed in c6828e5 As for the two nginx fixes mentioned:
I do agree that the URL itself in this repo has always been meetings, as far back as the official JS configuration ends. However, it is my understanding of the default behavior before this definition and in the |
Co-authored-by: Codex <noreply@openai.com>
|
I want to land this. thanks for the cleanup! the production slug is already
once those three are in, you might be better-off recrating this PR fresh from current main (probably easier than rebasing). you can ignore the crowdin file, too. that's another holdover from the old way of translating things. |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
It looks like 2361 and 2363 were successfully merged. I've synced this to |
ElliotFriend
left a comment
There was a problem hiding this comment.
this is looking pretty good to me! i'm not really sure about the src/pages/docs/notes.tsx addition, though. can you provide some more details on that?
Co-authored-by: Codex <noreply@openai.com>
ElliotFriend
left a comment
There was a problem hiding this comment.
let's do without the clientModule thing. we'll just live with the very few links that just so happen to not work 100%.
There was a problem hiding this comment.
to be honest, i'm ok with the few /docs/notes#1999-01-01-style links we have out there in the wild just being broken. there were only ever 4 entries on that page before we flipped over to the docusaurus blog plugin. (here's the page right before that went into effect.)
i think it's ok to let those very few link-followers just end up on /meetings here with a random url hash that doesn't do anything. let's cut this redirect module
There was a problem hiding this comment.
@kalepail, you're a main speaker in these meetings. Do you mind if previous soroban.stellar.org links referenced stop working? The meeting notes are still maintained on the main site.
Rename the meeting record from February 9 to February 8, following the prior correction documented in: stellar@c1c28a8 Co-authored-by: Codex <noreply@openai.com>
|
Obviously, you are free to remove this functionality and merge it in. My biggest gripe is that this meeting was incorrectly added with the following day's date. I fixed this in 64dd7ac, and hence I'd need this logic to redirect incorrect references to the actual meeting. It could get confusing if they land at the index, search for the date via slug or Algolia, and can't find that particular entry for an important proposed community standard. |
ElliotFriend
left a comment
There was a problem hiding this comment.
i think we can give folks the benefit of the doubt that they can find their way. i've resolved the existing conflicts and removed the client module. if we need to, we can implement it down the road if we find there is a need or demand for it.
thanks for all the work on this one!!
After #2375 for the contributior page guide, very other root folder and the vast majority of subfolders use a single-word name. It looks like the meetings held onto a legacy version, and this just updates that with a fix.
It moves the files and configures the build, as Copilot will surely parrot.
I think this makes a whole lot more sense, given the notes are really a tiny proportion of these pages, which focus on the actual meetings. And of course the production slug itself also just uses
meetings. Just makes diffs a whole lot cleaner to align the file names like that too.Warning
Affects 2388