Skip to content

📂 Change base dir from meeting-notes to just meetings#2390

Merged
ElliotFriend merged 21 commits into
stellar:mainfrom
JFWooten4:2145-pt-7
Jul 17, 2026
Merged

📂 Change base dir from meeting-notes to just meetings#2390
ElliotFriend merged 21 commits into
stellar:mainfrom
JFWooten4:2145-pt-7

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

After #2375 for the contributior page guide, very other root folder and the vast majority of subfolders use a single-word name. It looks like the meetings held onto a legacy version, and this just updates that with a fix.

It moves the files and configures the build, as Copilot will surely parrot.

I think this makes a whole lot more sense, given the notes are really a tiny proportion of these pages, which focus on the actual meetings. And of course the production slug itself also just uses meetings. Just makes diffs a whole lot cleaner to align the file names like that too.

Warning

Affects 2388

Copilot AI review requested due to automatic review settings April 24, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the Docusaurus “meeting notes” blog base directory to meetings to match the production slug and align with the repo’s single-word folder naming, updating build/tooling paths and adding redirects to preserve old URLs.

Changes:

  • Update Docusaurus blog config to use meetings as the blog path.
  • Update formatting (Prettier) and translation (Crowdin) globs to target meetings.
  • Add Nginx redirects from /meeting-notes to /meetings, and move meeting content into meetings/.

Reviewed changes

Copilot reviewed 4 out of 70 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Update Prettier scripts to format/check MD/MDX under meetings/ instead of meeting-notes/.
nginx/includes/redirects.conf Add permanent redirects from legacy /meeting-notes routes to /meetings.
docusaurus.config.ts Change Docusaurus blog path to meetings (route remains /meetings).
crowdin.yaml Update translation source path from /meeting-notes/**/* to /meetings/**/*.
meetings/authors.yml Add/relocate blog authors metadata under the new meetings/ directory.
meetings/2024-01-18.mdx Meeting post under meetings/.
meetings/2024-01-26.mdx Meeting post under meetings/.
meetings/2024-02-01.mdx Meeting post under meetings/.
meetings/2024-02-09.mdx Meeting post under meetings/.
meetings/2024-02-15.mdx Meeting post under meetings/.
meetings/2024-02-22.mdx Meeting post under meetings/.
meetings/2024-02-29.mdx Meeting post under meetings/.
meetings/2024-03-07.mdx Meeting post under meetings/.
meetings/2024-03-14.mdx Meeting post under meetings/.
meetings/2024-03-21.mdx Meeting post under meetings/.
meetings/2024-03-28.mdx Meeting post under meetings/.
meetings/2024-04-04.mdx Meeting post under meetings/.
meetings/2024-04-11.mdx Meeting post under meetings/.
meetings/2024-04-18.mdx Meeting post under meetings/.
meetings/2024-04-25.mdx Meeting post under meetings/.
meetings/2024-05-02.mdx Meeting post under meetings/.
meetings/2024-05-09.mdx Meeting post under meetings/.
meetings/2024-06-13.mdx Meeting post under meetings/.
meetings/2024-06-20.mdx Meeting post under meetings/.
meetings/2024-06-27.mdx Meeting post under meetings/.
meetings/2024-07-11.mdx Meeting post under meetings/.
meetings/2024-07-18.mdx Meeting post under meetings/.
meetings/2024-07-25.mdx Meeting post under meetings/.
meetings/2024-08-01.mdx Meeting post under meetings/.
meetings/2024-08-08.mdx Meeting post under meetings/.
meetings/2024-08-15.mdx Meeting post under meetings/.
meetings/2024-08-22.mdx Meeting post under meetings/.
meetings/2024-08-29.mdx Meeting post under meetings/.
meetings/2024-09-05.mdx Meeting post under meetings/.
meetings/2024-09-12.mdx Meeting post under meetings/.
meetings/2024-09-19.mdx Meeting post under meetings/.
meetings/2024-09-26.mdx Meeting post under meetings/.
meetings/2024-10-24.mdx Meeting post under meetings/.
meetings/2024-11-14.mdx Meeting post under meetings/.
meetings/2024-12-05.mdx Meeting post under meetings/.
meetings/2024-12-12.mdx Meeting post under meetings/.
meetings/2024-12-19.mdx Meeting post under meetings/.
meetings/2025-01-16.mdx Meeting post under meetings/.
meetings/2025-01-23.mdx Meeting post under meetings/.
meetings/2025-01-30.mdx Meeting post under meetings/.
meetings/2025-02-06.mdx Meeting post under meetings/.
meetings/2025-02-13.mdx Meeting post under meetings/.
meetings/2025-02-20.mdx Meeting post under meetings/.
meetings/2025-02-27.mdx Meeting post under meetings/.
meetings/2025-03-06.mdx Meeting post under meetings/.
meetings/2025-03-27.mdx Meeting post under meetings/.
meetings/2025-04-03.mdx Meeting post under meetings/.
meetings/2025-04-10.mdx Meeting post under meetings/.
meetings/2025-04-17.mdx Meeting post under meetings/.
meetings/2025-05-01.mdx Meeting post under meetings/.
meetings/2025-05-22.mdx Meeting post under meetings/.
meetings/2025-07-10.mdx Meeting post under meetings/.
meetings/2025-07-17.mdx Meeting post under meetings/.
meetings/2025-07-24.mdx Meeting post under meetings/.
meetings/2025-08-07.mdx Meeting post under meetings/.
meetings/2025-09-25.mdx Meeting post under meetings/.
meetings/2025-10-02.mdx Meeting post under meetings/.
meetings/2025-10-09.mdx Meeting post under meetings/.
meetings/2025-10-16.mdx Meeting post under meetings/.
meetings/2025-10-23.mdx Meeting post under meetings/.
meetings/2025-10-30.mdx Meeting post under meetings/.
meetings/2025-11-06.mdx Meeting post under meetings/.
meetings/2026-01-22.mdx Meeting post under meetings/.
meetings/2026-01-29.mdx Meeting post under meetings/.
meetings/2026-02-26.mdx Meeting post under meetings/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@briwylde08
briwylde08 requested a review from kaankacar April 27, 2026 16:47

@kaankacar kaankacar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Agree on the convention.

One thing on the nginx rewrites:

routeBasePath: 'meetings' has been set since the blog was first introduced — see 8abb6525(#449, April 2024). The path and routeBasePath have just been mismatched on disk all along; the URL has always been /meetings/... publicly. So /meeting-notes/... was never a live URL. There's nothing for those redirects to catch.

Unless I'm missing a case where one of those paths actually resolved, I'd drop both rules rather than land permanent rewrites for paths that never existed.

Otherwise LGTM!

@JFWooten4

Copy link
Copy Markdown
Contributor Author

Thank you for the comment. It reminded me that I missed an edge case from the original branch. Fixed in c6828e5

As for the two nginx fixes mentioned:

  1. The first fix redirects slugs of the form ^/meeting-notes/2020-10-30 to ^/meetings/2020/10/30

    • I added this forward because there are multiple pages on the official Stellar blog which use this form.
      • OK, well, "blog" is debatable, but the series of community event posts for the old protocol discussions.
      • Notwithstanding if they show up in the post list or RSS feed, those pages still exist on Google searches.
      • Some of them use this old reference structure, although I can only state that from memory when I write this back in the very beginning of February, as I've lost the links to time.
    • You can see this referenced in the Discord by old Stella training data.
  2. Given the existence of the above mislinks, which does not even begin to explore the web inconsistencies across places like Reddit, I thought the second redirect would be a good safety measure to save a little reader confusion, since the meetings list page is so hard to find from its sole location in the footer.

I do agree that the URL itself in this repo has always been meetings, as far back as the official JS configuration ends. However, it is my understanding of the default behavior before this definition and in the old-docs import that before the defined method it just inherited the folder-structure name. And thus that's why I think we have these historical references in official and community media which use the wrong base path.

Co-authored-by: Codex <noreply@openai.com>
@ElliotFriend

Copy link
Copy Markdown
Contributor

I want to land this. thanks for the cleanup! the production slug is already /meetings, so the rename makes sense. i think there was a previous version of docusaurus that did put in links like meeting-notes/..., so the redirect does seem to fit. But sequencing is gonna matter here:

  1. It's conflicting with main now, and the rename list stops at 2026-05-07 — main has meeting files past that date.
  2. i'm trying merge the embed-component PRs (Use the YouTube embed screen in existing meeting files #2361Use custom audio embed screen in existing meeting files #2363) first, and rebasing a 75-file rename across those would be painful in the wrong order.

once those three are in, you might be better-off recrating this PR fresh from current main (probably easier than rebasing).

you can ignore the crowdin file, too. that's another holdover from the old way of translating things.

JFWooten4 and others added 2 commits July 13, 2026 15:44
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@JFWooten4

Copy link
Copy Markdown
Contributor Author

It looks like 2361 and 2363 were successfully merged. I've synced this to main and found no lingering iframe embeds to replace. And I've removed the changes to crowdin.yaml.

@ElliotFriend ElliotFriend left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking pretty good to me! i'm not really sure about the src/pages/docs/notes.tsx addition, though. can you provide some more details on that?

Comment thread nginx/includes/redirects.conf
Comment thread src/pages/docs/notes.tsx Outdated
Co-authored-by: Codex <noreply@openai.com>

@ElliotFriend ElliotFriend left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do without the clientModule thing. we'll just live with the very few links that just so happen to not work 100%.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, i'm ok with the few /docs/notes#1999-01-01-style links we have out there in the wild just being broken. there were only ever 4 entries on that page before we flipped over to the docusaurus blog plugin. (here's the page right before that went into effect.)

i think it's ok to let those very few link-followers just end up on /meetings here with a random url hash that doesn't do anything. let's cut this redirect module

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalepail, you're a main speaker in these meetings. Do you mind if previous soroban.stellar.org links referenced stop working? The meeting notes are still maintained on the main site.

Rename the meeting record from February 9 to February 8, following the prior correction documented in:
stellar@c1c28a8

Co-authored-by: Codex <noreply@openai.com>
@JFWooten4

Copy link
Copy Markdown
Contributor Author

Obviously, you are free to remove this functionality and merge it in. My biggest gripe is that this meeting was incorrectly added with the following day's date. I fixed this in 64dd7ac, and hence I'd need this logic to redirect incorrect references to the actual meeting. It could get confusing if they land at the index, search for the date via slug or Algolia, and can't find that particular entry for an important proposed community standard.

@ElliotFriend ElliotFriend left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can give folks the benefit of the doubt that they can find their way. i've resolved the existing conflicts and removed the client module. if we need to, we can implement it down the road if we find there is a need or demand for it.

thanks for all the work on this one!!

@ElliotFriend
ElliotFriend merged commit e62c3f3 into stellar:main Jul 17, 2026
5 of 6 checks passed
@JFWooten4
JFWooten4 deleted the 2145-pt-7 branch July 18, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants