Skip to content

Add SEP-58 bldarg for arguments ahead of bldopt#1965

Merged
leighmcculloch merged 25 commits into
masterfrom
sep58-bldarg-ordered-args
Jul 20, 2026
Merged

Add SEP-58 bldarg for arguments ahead of bldopt#1965
leighmcculloch merged 25 commits into
masterfrom
sep58-bldarg-ordered-args

Conversation

@leighmcculloch

@leighmcculloch leighmcculloch commented Jun 19, 2026

Copy link
Copy Markdown
Member

What

Add a bldarg field to SEP-58. bldarg is an ordered list of arguments injected ahead of the existing bldopt entries. When no bldarg is present it defaults to contract then build. bldopt is unchanged.

Why

The change is additive. Existing records use bldopt against an assumed contract build baseline, and keeping bldopt leaves those valid. bldarg makes that baseline explicit and overridable for builds whose leading arguments differ, and can carry positional arguments or flags. Producers that only deviate by a flag keep using bldopt alone, so contract and build need not be recorded.

Discussion:

@leighmcculloch
leighmcculloch marked this pull request as ready for review June 19, 2026 11:05
Copilot AI review requested due to automatic review settings June 19, 2026 11:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4679db5625

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ecosystem/sep-0058.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SEP-58 (Contract Build Reproducibility for Verification) to rename the build metadata field from bldopt to bldarg and redefine it as an ordered, verbatim-replayed argument list for reproducible contract builds, expanding support to include positional arguments (e.g. contract, build) and adding guidance on treating producer-supplied arguments as untrusted.

Changes:

  • Renames bldoptbldarg and redefines it as an ordered list of CLI arguments to replay verbatim.
  • Updates rationale, security concerns, and Appendix A examples to reflect the new field semantics.
  • Bumps SEP version to 0.6.0 and records the change in the changelog.

Comment thread ecosystem/sep-0058.md Outdated
Comment thread ecosystem/sep-0058.md Outdated
Comment thread ecosystem/sep-0058.md Outdated
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 264f8152bb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ecosystem/sep-0058.md Outdated
@leighmcculloch leighmcculloch changed the title Rework SEP-58 bldopt into ordered bldarg list Add SEP-58 bldarg for arguments ahead of bldopt Jul 14, 2026

Copy link
Copy Markdown
Member Author

Reworked this to be additive instead of a rename.

bldopt stays exactly as it was. New bldarg is an ordered list injected ahead of bldopt, defaulting to contract then build when absent. It can carry positional arguments or flags. Existing bldopt-only records stay valid, and producers can omit bldarg so contract and build need not be recorded.


Generated by Claude Code

@leighmcculloch
leighmcculloch requested a review from fnando July 15, 2026 02:47
Comment thread ecosystem/sep-0058.md
Comment thread ecosystem/sep-0058.md
Comment thread ecosystem/sep-0058.md Outdated
fnando
fnando previously approved these changes Jul 15, 2026

@fnando fnando left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, but looking good! 👍

@leighmcculloch
leighmcculloch requested a review from fnando July 16, 2026 06:39
Comment thread ecosystem/sep-0058.md
@leighmcculloch
leighmcculloch merged commit aed3394 into master Jul 20, 2026
7 checks passed
@leighmcculloch
leighmcculloch deleted the sep58-bldarg-ordered-args branch July 20, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants