Add SEP-58 bldarg for arguments ahead of bldopt#1965
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4679db5625
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates SEP-58 (Contract Build Reproducibility for Verification) to rename the build metadata field from bldopt to bldarg and redefine it as an ordered, verbatim-replayed argument list for reproducible contract builds, expanding support to include positional arguments (e.g. contract, build) and adding guidance on treating producer-supplied arguments as untrusted.
Changes:
- Renames
bldopt→bldargand redefines it as an ordered list of CLI arguments to replay verbatim. - Updates rationale, security concerns, and Appendix A examples to reflect the new field semantics.
- Bumps SEP version to
0.6.0and records the change in the changelog.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 264f8152bb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Reworked this to be additive instead of a rename.
Generated by Claude Code |
fnando
left a comment
There was a problem hiding this comment.
Made a few comments, but looking good! 👍
What
Add a
bldargfield to SEP-58.bldargis an ordered list of arguments injected ahead of the existingbldoptentries. When nobldargis present it defaults tocontractthenbuild.bldoptis unchanged.Why
The change is additive. Existing records use
bldoptagainst an assumedcontract buildbaseline, and keepingbldoptleaves those valid.bldargmakes that baseline explicit and overridable for builds whose leading arguments differ, and can carry positional arguments or flags. Producers that only deviate by a flag keep usingbldoptalone, socontractandbuildneed not be recorded.Discussion: