feat(mcp): add privacy-safe recall receipts#1053
Closed
SiddheshCodes4554 wants to merge 2 commits into
Closed
Conversation
ishaanxgupta
left a comment
Contributor
There was a problem hiding this comment.
The receipt hashing is deterministic when RECEIPT_HASH_SALT is unset because privacyHash() defaults to salt = "" and hashes ${salt}:${input} with plain SHA-256. That means raw queries, project ids, memory ids, and short memory contents can be dictionary-guessed and correlated across receipts, which contradicts the “privacy-safe” behavior described in the PR. Please either require a secret salt and fail/disable receipts without it, or use a per-receipt random HMAC salt that is not emitted so receipts are unlinkable by default.
Member
|
not planned as of now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional, privacy-safe receipt mechanism for MCP recall operations so users can debug cross-client memory behavior without exposing raw memory content, prompts, or repository text.
Why
In multi-client workflows (Cursor, Claude Code, VS Code, etc.), debugging failures like:
currently requires sharing sensitive raw content.
What’s Included
receipt shape/type