fix memory render#1087
Conversation
|
Claude finished @ishaanxgupta's task in 46s —— View job Review Complete
Overview: Simplifies edge source/target node lookup by reusing the already-computed Issues found: None — this looks good to ship. The change at // Old - redundant type check
const src = typeof edge.source === "string" ? nodeMap.get(edge.source) : edge.source
// New - clean reuse
const src = nodeMap.get(srcId)The new approach is actually safer — it always looks up nodes from Score: 10/10 |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 85caa11 | Jun 14 2026, 06:14 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 85caa11 | Commit Preview URL Branch Preview URL |
Jun 14 2026, 06:14 PM |
Removed outdated comments regarding edge source/target resolution.
There was a problem hiding this comment.
Overview: Simplifies edge source/target node lookup by reusing the already-computed srcId/tgtId variables instead of redundant type checking.
Issues found: None — this looks good to ship.
The change correctly leverages the existing type handling at lines 227-228 where srcId and tgtId are extracted. The old code duplicated this type check unnecessarily. The new code is cleaner and always looks up nodes from nodeMap, which is actually safer as it ensures consistent node references rather than potentially using stale objects stored directly in edge data.
Score: 10/10
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Apply changes from code browser
Downgrade @supermemory/memory-graph version from 0.2.3 to 0.2.0.
No description provided.