Skip to content

fix memory render#1087

Merged
ishaanxgupta merged 6 commits into
mainfrom
fix-graph-render
Jun 14, 2026
Merged

fix memory render#1087
ishaanxgupta merged 6 commits into
mainfrom
fix-graph-render

Conversation

@ishaanxgupta

Copy link
Copy Markdown
Contributor

No description provided.

@claude

claude Bot commented Jun 10, 2026

Copy link
Copy Markdown

Claude finished @ishaanxgupta's task in 46s —— View job


Review Complete

  • Analyzing PR changes
  • Checking for bugs and security issues
  • Submitting review

Overview: Simplifies edge source/target node lookup by reusing the already-computed srcId/tgtId variables instead of redundant type checking, along with a patch version bump.

Issues found: None — this looks good to ship.

The change at renderer.ts:247-248 correctly leverages the existing type handling at lines 227-228 where srcId and tgtId are extracted. The old code duplicated this type check unnecessarily:

// Old - redundant type check
const src = typeof edge.source === "string" ? nodeMap.get(edge.source) : edge.source
// New - clean reuse
const src = nodeMap.get(srcId)

The new approach is actually safer — it always looks up nodes from nodeMap, ensuring consistent node references rather than potentially using stale objects stored directly in edge data.

Score: 10/10

@graphite-app graphite-app Bot requested a review from Dhravya June 10, 2026 15:35
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 85caa11 Jun 14 2026, 06:14 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 85caa11 Commit Preview URL

Branch Preview URL
Jun 14 2026, 06:14 PM

Removed outdated comments regarding edge source/target resolution.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Simplifies edge source/target node lookup by reusing the already-computed srcId/tgtId variables instead of redundant type checking.

Issues found: None — this looks good to ship.

The change correctly leverages the existing type handling at lines 227-228 where srcId and tgtId are extracted. The old code duplicated this type check unnecessarily. The new code is cleaner and always looks up nodes from nodeMap, which is actually safer as it ensures consistent node references rather than potentially using stale objects stored directly in edge data.

Score: 10/10

github-actions Bot and others added 4 commits June 11, 2026 14:59
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Apply changes from code browser
Downgrade @supermemory/memory-graph version from 0.2.3 to 0.2.0.
@ishaanxgupta ishaanxgupta merged commit 42b1920 into main Jun 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants