Add generative quantum advantage tutorial for issue #909.#1094
Add generative quantum advantage tutorial for issue #909.#1094rosspeili wants to merge 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Code Review
This pull request introduces a new tutorial notebook, generative_quantum_advantage.ipynb, demonstrating generative quantum advantage using TensorFlow Quantum, along with registering it in _book.yaml and updating test_tutorials.py to scale down parameters for faster testing. A critical mathematical bug was identified in the parameter shift gradient calculation: the parameter shift rule is incorrectly applied directly to the non-linear negative log-likelihood loss function rather than the underlying probabilities, which leads to incorrect gradients. A code suggestion is provided to resolve this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@mhucka let me know how this looks, or if I should add more sections, or anything else I might be forgetting. Thanks in advance <3 |
New TFQ tutorial based on arxiv:2509.09033 on generative quantum advantage, walks through a small 8-qubit demo, build a shallow ansatz, create training bitstrings, train with TFQ (
get_state_op+ parameter shift), and sample withget_sampling_op.Also updates
docs/_book.yamland adds CI runtime caps inscripts/test_tutorials.py.Closes #909