fix for gradle tools 9#420
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@hansemannn since the gradle 9 update was merged into 13.3.0 we have to merge this one here too (was linked in the other PR). Otherwise building hyperloop apps will show: Test module: hyperloop-android-8.0.0.zip |
| jobs: | ||
| android: | ||
| runs-on: macos-13 | ||
| runs-on: macos-15 |
There was a problem hiding this comment.
Is there a reason not to use macos-26 here?
There was a problem hiding this comment.
I've look at https://github.com/tidev/titanium-sdk/blob/main/.github/workflows/build.yml#L27 and used that version.
There was a problem hiding this comment.
Same applies to here. But if you're upgrading here already, it should not be to an outdated macOS version
| # | ||
| # An overview of macOS <> Xcode <> Swift versions can be found here: https://developer.apple.com/support/xcode/ | ||
| DEVELOPER_DIR: /Applications/Xcode_14.3.1.app/Contents/Developer | ||
| DEVELOPER_DIR: /Applications/Xcode_26.2.app/Contents/Developer |
There was a problem hiding this comment.
Align with latest Xcode version available on the macos-26 runner
There was a problem hiding this comment.
There was a problem hiding this comment.
won't we get Unsupported Swift architecture errors when I raise this version here (Swift 6.3) and the SDK still has Xcode 26.2 (Swift 6.2.3)? But we can change this once we update the iOS version of Hyperloop. As there are only changes for Android we don't need to release a new iOS version.
| } | ||
|
|
||
| // Extract classes.jar from AAR files so the metabase generator (BCEL) can load them. | ||
| // BCEL requires .jar files on the classpath; it cannot read .aar files directly. |
There was a problem hiding this comment.
Btw, we should consider discontinuing manual .aar support - it's a supply-chain risk as well.
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
fixing gradle issues, needed for tidev/titanium-sdk#14410