Skip to content

fix for gradle tools 9#420

Open
m1ga wants to merge 9 commits into
masterfrom
gradle9Fixes
Open

fix for gradle tools 9#420
m1ga wants to merge 9 commits into
masterfrom
gradle9Fixes

Conversation

@m1ga

@m1ga m1ga commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

fixing gradle issues, needed for tidev/titanium-sdk#14410

  • fix gradle 9 parts (e.g. load external libraries)
  • upgrade commons-lang3
  • upgrade npm packages

@m1ga m1ga marked this pull request as draft May 19, 2026 11:45
@socket-security

socket-security Bot commented May 19, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtitanium@​5.4.1 ⏵ 8.1.579 +2100100 +195 +6100

View full report

@m1ga m1ga marked this pull request as ready for review May 19, 2026 12:34
@m1ga

m1ga commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@hansemannn since the gradle 9 update was merged into 13.3.0 we have to merge this one here too (was linked in the other PR). Otherwise building hyperloop apps will show:

[ERROR] [GRADLE] 
[ERROR] [GRADLE] FAILURE: Build failed with an exception.
[ERROR] [GRADLE] 
[ERROR] [GRADLE] * Where:
[ERROR] [GRADLE] Build file '/home/miga/tools/hyperloop-examples/build/hyperloop/android/gradle-project/build.gradle' line: 56
[ERROR] [GRADLE] 
[ERROR] [GRADLE] * What went wrong:
[ERROR] [GRADLE] Execution failed for task ':gradle-project:generateJarDependenciesFile'.
[ERROR] [GRADLE] > Could not get unknown property 'sdkDirectory' for object of type com.android.build.gradle.internal.dsl.LibraryExtensionImpl$AgpDecorated.
[ERROR] [GRADLE] 
[ERROR] [GRADLE] * Try:
[ERROR] [GRADLE] > Run with --stacktrace option to get the stack trace.
[ERROR] [GRADLE] > Run with --info or --debug option to get more log output.
[ERROR] [GRADLE] > Run with --scan to get full insights from a Build Scan (powered by Develocity).
[ERROR] [GRADLE] > Get more help at https://help.gradle.org.
[ERROR] [GRADLE] 
[ERROR] [GRADLE] BUILD FAILED in 9s
[ERROR] "gradlew" tool returned exit code: 1

Test module: hyperloop-android-8.0.0.zip

@m1ga m1ga requested a review from hansemannn June 17, 2026 15:19
Comment thread .github/workflows/android.yml Outdated
jobs:
android:
runs-on: macos-13
runs-on: macos-15

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to use macos-26 here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies to here. But if you're upgrading here already, it should not be to an outdated macOS version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is 26 now

Comment thread .github/workflows/ios.yml Outdated
Comment thread .github/workflows/ios.yml
#
# An overview of macOS <> Xcode <> Swift versions can be found here: https://developer.apple.com/support/xcode/
DEVELOPER_DIR: /Applications/Xcode_14.3.1.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_26.2.app/Contents/Developer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with latest Xcode version available on the macos-26 runner

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't we get Unsupported Swift architecture errors when I raise this version here (Swift 6.3) and the SDK still has Xcode 26.2 (Swift 6.2.3)? But we can change this once we update the iOS version of Hyperloop. As there are only changes for Android we don't need to release a new iOS version.

}

// Extract classes.jar from AAR files so the metabase generator (BCEL) can load them.
// BCEL requires .jar files on the classpath; it cannot read .aar files directly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, we should consider discontinuing manual .aar support - it's a supply-chain risk as well.

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm execa is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: package-lock.jsonnpm/titanium@8.1.5npm/execa@9.6.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/execa@9.6.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants