tail: treat a watched file replaced by a symlink as untailable#12661
Open
sylvestre wants to merge 1 commit into
Open
tail: treat a watched file replaced by a symlink as untailable#12661sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
Under --follow=name, handle_event used metadata() (which follows symlinks), so a watched file swapped for a symlink was silently followed to the link target, exfiltrating its contents. Check symlink_metadata() and report the replacement as an untailable symbolic link, matching GNU.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under --follow=name, handle_event used metadata() (which follows symlinks), so a watched file swapped for a symlink was silently followed to the link target, exfiltrating its contents. Check symlink_metadata() and report the replacement as an untailable symbolic link, matching GNU.