ci(e2e): remove vinext vp check workaround#1615
Closed
fengmk2 wants to merge 3 commits into
Closed
Conversation
vinext's upstream main now reflects oxlint 1.63's `eslint-` prefix removal, so `vp check --fix` and `vp run check` no longer need the `|| true` report-only escape hatch. Bump the pinned hash to pick up the source-side fix.
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
|
required #1609 |
Member
Author
|
fix in #1767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-prefix removal (oxc-project/oxc#21806), sovp check --fixandvp run checkno longer need the|| truereport-only escape hatch in the ecosystem-ci matrix.a1d2b610→d558923f) to pick up the source-side fix.vp checkagainst vinext will fail the e2e matrix instead of being silently swallowed.Test plan
vinextjob without|| true.