Skip to content

fmt: normalize_comments = true#8428

Draft
joseph-isaacs wants to merge 2 commits into
developfrom
ji/norm-comments
Draft

fmt: normalize_comments = true#8428
joseph-isaacs wants to merge 2 commits into
developfrom
ji/norm-comments

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add normalize_comments = true rust-lang/rustfmt#3350

@joseph-isaacs
fmt: normalize_comments = true
15093f8 
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
AdamGS
AdamGS reviewed Jun 15, 2026
View reviewed changes
Comment thread vortex-array/src/arrays/chunked/array.rs
PrimitiveArray::new(buffer![0u64; 0], Validity::AllValid).into_array(), // empty chunk
PrimitiveArray::new(buffer![3u64, 4], Validity::AllInvalid).into_array(),
PrimitiveArray::new(buffer![0u64; 0], Validity::AllInvalid).into_array(), // empty chunk
PrimitiveArray::new(buffer![0u64; 0], Validity::AllInvalid).into_array(), /* empty chunk */

@AdamGS AdamGS Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is horrible

onursatici
onursatici reviewed Jun 15, 2026
View reviewed changes
Comment thread vortex-array/src/arrays/chunked/array.rs
@@ -410,7 +410,7 @@ mod test {
PrimitiveArray::new(buffer![1u64, 2], Validity::AllValid).into_array(),
PrimitiveArray::new(buffer![0u64; 0], Validity::AllValid).into_array(), // empty chunk

@onursatici onursatici Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this survive

connortsui20
connortsui20 reviewed Jun 15, 2026
View reviewed changes
Comment thread vortex-array/src/arrays/patched/mod.rs
//!
//! ```text
//!
//!

@connortsui20 connortsui20 Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@joseph-isaacs joseph-isaacs added the changelog/chore A trivial change label Jun 15, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1545 untouched benchmarks
⏩ 10 skipped benchmarks1

Comparing ji/norm-comments (1e2c9b2) with develop (d737639)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@joseph-isaacs
fmt
1e2c9b2 
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onursatici onursatici onursatici left review comments

@AdamGS AdamGS AdamGS left review comments

@connortsui20 connortsui20 connortsui20 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joseph-isaacs @onursatici @AdamGS @connortsui20