Skip to content

Don't auto-submit multi-select agent questions on toggle#12545

Draft
coolcom200 wants to merge 1 commit into
masterfrom
oz-agent/multiselect-no-autosubmit
Draft

Don't auto-submit multi-select agent questions on toggle#12545
coolcom200 wants to merge 1 commit into
masterfrom
oz-agent/multiselect-no-autosubmit

Conversation

@coolcom200

Copy link
Copy Markdown
Contributor

Description

For the AskUserQuestion tool, the last multi-select question would auto-submit the whole questionnaire as soon as a single option was toggled — whether by clicking it with the mouse or pressing its number key. This made it impossible to select more than one option (the reported case: a user clicked the first option intending to also click the next, but it submitted after the first click).

Multi-select questions now never auto-submit on toggle. Options are toggled explicitly via mouse click or number keys, and the user submits the question with Enter. Single-select behavior is unchanged (toggling an option still auto-advances / auto-submits the last question).

Changes

  • ask_user_question_auto_advance_enabled now keys off is_multiselect only — single-select auto-advances, multi-select never does.
  • toggle_option no longer schedules an auto-advance for multi-select questions.
  • save_other_text follows the same rule for the "Other…" free-text path on multi-select questions.
  • press_enter no longer toggles the highlighted option for multi-select; it just commits the current selection and submits/advances (single-select still activates the highlighted option on Enter). This also fixes Enter accidentally un-toggling the last-clicked/hovered option in multi-select.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Updated and extended the ask_user_question_view unit tests to cover the new behavior, and ran them:

cargo nextest run -p warp -E 'test(ask_user_question_view)'
19 tests run: 19 passed
  • New/updated tests: last_multi_select_toggle_does_not_auto_advance, last_multi_select_submits_on_enter, enter_on_multi_select_does_not_toggle_highlighted_option, enter_on_answered_multi_select_keeps_selection_without_toggling_highlighted_option.

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Conversation: https://staging.warp.dev/conversation/5044c0f2-de4e-4143-989e-7e55b7a6c62e
Run: https://oz.staging.warp.dev/runs/019eb8d5-5f41-77df-b381-ce5db367205a

This PR was generated with Oz.

For AskUserQuestion, the last multi-select question previously auto-submitted
the questionnaire as soon as a single option was toggled via mouse click or
number key. This made it impossible to select more than one option before the
answer was submitted.

Multi-select questions now never auto-submit on toggle. Options are toggled
explicitly via click/number keys and the user submits with Enter. Single-select
behavior (auto-advance/auto-submit on selection) is unchanged. Enter also no
longer toggles the highlighted option for multi-select; it just commits the
current selection.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant