feat(pages): add branding#120
Open
avivkeller wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Open
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated branding page to the doc site and adjusts doc generation configuration to correctly resolve version-scoped site metadata during HTML generation.
Changes:
- Added a new
pages/about/branding.mdpage documenting webpack brand assets, colors, and trademark guidance (with links to OpenJS artwork and policy). - Simplified
scripts/html/doc-kit.config.mjsinput directory handling and fixed#theme/local/siteimport resolution for versioned builds. - Updated
package-lock.jsonto reflect a lockfile regeneration/cleanup (removing some metadata and an extraneous entry).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/html/doc-kit.config.mjs | Adjusts doc-kit path configuration and local site.json import resolution. |
| pages/about/branding.md | Introduces the new branding/trademark guidelines page and asset references. |
| package-lock.json | Lockfile cleanup/regeneration changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @webpack/tsc @rginn to approve the language used in this branding page. I'm not a lawyer. See https://webpack-doc-kit-git-branding-openjs.vercel.app/about/branding.