fix: variable shadowing crash in cancel, duplicate FilePicker modal#473
Open
fix2015 wants to merge 1 commit into
Open
fix: variable shadowing crash in cancel, duplicate FilePicker modal#473fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
- handleCancelExecution declared a local const sessionStartTime that shadowed the useRef of the same name — accessing .current on the local number would crash with TypeError every time a user cancelled - the FilePicker modal block was copy-pasted and rendered twice in App.tsx, causing two overlapping modals to appear and both onSelect handlers to fire simultaneously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs:
`handleCancelExecution` declared a local `const sessionStartTime` (a number) that shadowed the `useRef` of the same name at the top of the component. When the code later accesses `sessionStartTime.current`, it's trying to read `.current` on a plain number instead of a ref — crashes with TypeError every time a user cancels execution. Renamed the local variable.
The `showProjectPicker` modal block was copy-pasted and rendered twice in App.tsx (two identical blocks). When the user opens the file picker, two overlapping modals appear and both `onSelect` handlers fire, potentially creating duplicate projects or corrupting state. Removed the duplicate.