Skip to content

feat: Display drive section for guests added to a team with drive enabled (WPB-25214)#4855

Merged
ohassine merged 27 commits into
developfrom
display-drive-section-for-guests-added-to-a-team-with-Drive-enabled
Jun 16, 2026
Merged

feat: Display drive section for guests added to a team with drive enabled (WPB-25214)#4855
ohassine merged 27 commits into
developfrom
display-drive-section-for-guests-added-to-a-team-with-Drive-enabled

Conversation

@ohassine

@ohassine ohassine commented May 21, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-25214


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently Drive section is not displayed for guests

Solutions

Show it to guests if they are added to a conversation with drive enabled

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title Display drive section for guests added to a team with drive enabled feat: Display drive section for guests added to a team with drive enabled May 21, 2026
@ohassine ohassine requested review from sbakhtiarov and yamilmedina and removed request for yamilmedina May 21, 2026 10:34
@ohassine ohassine requested a review from yamilmedina May 21, 2026 11:21
observeTeamManagementUrlForUser()
) { wireCellsEnabled, unreadArchiveConversationsCount, teamManagementUrl ->
observeTeamManagementUrlForUser(),
observeConversationListDetails.get().invoke(fromArchive = false)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

observeConversationListDetails is

  1. A complex query (I think we should avoid calling it unless absolutely necessary)
  2. Will change a lot (which will cause constant drawer items list rebuilds for no reason)

I suggest:

  • use existing hasConversationWithCell() query (make the observable version if needed).
  • create a use case for observing it which returns Flow with distinctUntilChanged() to avoid unnecessary updates and keep all business logic in kalium

@ohassine ohassine requested a review from sbakhtiarov June 8, 2026 16:02
ohassine added 2 commits June 8, 2026 17:04
…ewers-profile' into display-drive-section-for-guests-added-to-a-team-with-Drive-enabled

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/drawer/HomeDrawerViewModel.kt
@ohassine ohassine changed the title feat: Display drive section for guests added to a team with drive enabled feat: Display drive section for guests added to a team with drive enabled (WPB-25214) Jun 8, 2026
Comment thread app/src/main/kotlin/com/wire/android/ui/home/drawer/HomeDrawerViewModel.kt Outdated
@ohassine ohassine requested a review from sbakhtiarov June 11, 2026 11:38
Base automatically changed from Restrict-access-to-upload-for-Viewers-profile to develop June 12, 2026 13:57
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Jun 12, 2026
…ion-for-guests-added-to-a-team-with-Drive-enabled

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/composer/MessageComposerViewModel.kt
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Jun 15, 2026
@ohassine ohassine enabled auto-merge June 16, 2026 09:59
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.77%. Comparing base (3f2dceb) to head (49065b9).

Files with missing lines Patch % Lines
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (63.63%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4855   +/-   ##
========================================
  Coverage    48.76%   48.77%           
========================================
  Files          644      644           
  Lines        23145    23151    +6     
  Branches      3545     3546    +1     
========================================
+ Hits         11287    11292    +5     
- Misses       10809    10811    +2     
+ Partials      1049     1048    -1     
Files with missing lines Coverage Δ
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 97.82% <100.00%> (+4.80%) ⬆️
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2dceb...49065b9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine ohassine added this pull request to the merge queue Jun 16, 2026
Merged via the queue into develop with commit 1a89867 Jun 16, 2026
19 checks passed
@ohassine ohassine deleted the display-drive-section-for-guests-added-to-a-team-with-Drive-enabled branch June 16, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants