feat: Display drive section for guests added to a team with drive enabled (WPB-25214)#4855
Conversation
…ewers-profile' into Restrict-access-to-upload-for-Viewers-profile
…-upload-for-Viewers-profile
…ewers-profile' into Display-“Drive”-section-for-guests-added-to-a-team-with-Drive-enabled
| observeTeamManagementUrlForUser() | ||
| ) { wireCellsEnabled, unreadArchiveConversationsCount, teamManagementUrl -> | ||
| observeTeamManagementUrlForUser(), | ||
| observeConversationListDetails.get().invoke(fromArchive = false) |
There was a problem hiding this comment.
observeConversationListDetails is
- A complex query (I think we should avoid calling it unless absolutely necessary)
- Will change a lot (which will cause constant drawer items list rebuilds for no reason)
I suggest:
- use existing hasConversationWithCell() query (make the observable version if needed).
- create a use case for observing it which returns Flow with distinctUntilChanged() to avoid unnecessary updates and keep all business logic in kalium
…-upload-for-Viewers-profile
…play-drive-section-for-guests-added-to-a-team-with-Drive-enabled
…-upload-for-Viewers-profile # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationCoreViewModelFactory.kt
…ewers-profile' into display-drive-section-for-guests-added-to-a-team-with-Drive-enabled # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/drawer/HomeDrawerViewModel.kt
…ion-for-guests-added-to-a-team-with-Drive-enabled # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/composer/MessageComposerViewModel.kt
…-a-team-with-Drive-enabled
…-a-team-with-Drive-enabled
…-a-team-with-Drive-enabled
…-a-team-with-Drive-enabled
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (63.63%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4855 +/- ##
========================================
Coverage 48.76% 48.77%
========================================
Files 644 644
Lines 23145 23151 +6
Branches 3545 3546 +1
========================================
+ Hits 11287 11292 +5
- Misses 10809 10811 +2
+ Partials 1049 1048 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|



https://wearezeta.atlassian.net/browse/WPB-25214
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Currently Drive section is not displayed for guests
Solutions
Show it to guests if they are added to a conversation with drive enabled
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.