Skip to content

test: cover metro session runtime flows [WPB-25946]#4954

Open
Garzas wants to merge 3 commits into
developfrom
test/metro-session-runtime-stability
Open

test: cover metro session runtime flows [WPB-25946]#4954
Garzas wants to merge 3 commits into
developfrom
test/metro-session-runtime-stability

Conversation

@Garzas

@Garzas Garzas commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25946


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adds regression coverage for the Metro session runtime flows that were breaking during the Hilt to Metro migration.

The tests cover:

  • login path that reaches the too-many-devices flow,
  • cancelling/removing a device from the too-many-devices screen,
  • returning from add-account login back to an existing session,
  • logout/session transition behavior,
  • removed-client event handling when another account is available,
  • removed-client event handling when no other account is available.

Why

These scenarios caught the recent runtime regressions around session-scoped Metro graphs, account switching, logout, and client removal. Keeping them covered should make the remaining Metro migration safer and prevent us from reintroducing white screens, stale session graphs, or wrong-account state.

Validation

  • Added critical-flow style UI test coverage for the session/account edge cases.
  • Branch is stacked on top of fix/metro-session-runtime-stability.

@Garzas Garzas requested review from emmaoke-w and yamilmedina June 10, 2026 09:37
@Garzas Garzas self-assigned this Jun 10, 2026
@Garzas Garzas requested a review from MohamadJaara June 10, 2026 09:37
@Garzas Garzas force-pushed the fix/metro-session-runtime-stability branch from df22494 to 4d78a38 Compare June 10, 2026 10:29
@Garzas Garzas requested a review from a team as a code owner June 10, 2026 10:29
@Garzas Garzas requested review from ohassine and saleniuk and removed request for a team June 10, 2026 10:29
@Garzas Garzas force-pushed the test/metro-session-runtime-stability branch from d012b53 to 3e13026 Compare June 10, 2026 10:30
@Garzas Garzas force-pushed the fix/metro-session-runtime-stability branch from 4d78a38 to 94b4fed Compare June 10, 2026 10:51
@Garzas Garzas force-pushed the test/metro-session-runtime-stability branch from 3e13026 to 4c06901 Compare June 10, 2026 10:52
@MohamadJaara

MohamadJaara commented Jun 10, 2026

Copy link
Copy Markdown
Member

can you please add it to regression tests please instead of critical flow or sync with @emmaoke-w if it must be in critical?

@Garzas Garzas force-pushed the fix/metro-session-runtime-stability branch from 7d720f0 to d496d44 Compare June 10, 2026 16:26
Base automatically changed from fix/metro-session-runtime-stability to develop June 10, 2026 16:56
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@Garzas Garzas force-pushed the test/metro-session-runtime-stability branch from 4c06901 to 528307c Compare June 17, 2026 05:38
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.93%. Comparing base (363bb88) to head (828633e).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4954      +/-   ##
===========================================
+ Coverage    48.79%   48.93%   +0.14%     
===========================================
  Files          646      646              
  Lines        23159    23168       +9     
  Branches      3545     3552       +7     
===========================================
+ Hits         11300    11337      +37     
+ Misses       10812    10779      -33     
- Partials      1047     1052       +5     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363bb88...828633e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants